Issue #5360: Add /usr/bin/env to COPY_EXEC_LIST in initramfs hooks. #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penzfs#5360. 5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. Signed-off-by: James Dingwall <james.dingwall@zynstra.com>
behlendorf
approved these changes
Dec 1, 2017
gmelikov
approved these changes
Dec 1, 2017
dinatale2
approved these changes
Dec 1, 2017
Codecov Report
@@ Coverage Diff @@
## master #6913 +/- ##
==========================================
+ Coverage 75.18% 75.26% +0.07%
==========================================
Files 296 296
Lines 95197 95197
==========================================
+ Hits 71577 71648 +71
+ Misses 23620 23549 -71
Continue to review full report at Codecov.
|
rlaager
approved these changes
Dec 2, 2017
tonyhutter
pushed a commit
that referenced
this pull request
Dec 5, 2017
5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: James Dingwall <james.dingwall@zynstra.com> Closes #5360 Closes #6913 Conflicts: contrib/initramfs/hooks/zfs
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 5, 2017
5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: James Dingwall <james.dingwall@zynstra.com> Closes openzfs#5360 Closes openzfs#6913 Conflicts: contrib/initramfs/hooks/zfs
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Jan 29, 2018
5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: James Dingwall <james.dingwall@zynstra.com> Closes openzfs#5360 Closes openzfs#6913
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Feb 13, 2018
5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: James Dingwall <james.dingwall@zynstra.com> Closes openzfs#5360 Closes openzfs#6913
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Apr 28, 2019
5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: James Dingwall <james.dingwall@zynstra.com> Closes openzfs#5360 Closes openzfs#6913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
5dc1ff2 changed the user space program to mount a zfs snapshot from /bin/sh to /usr/bin/env. If the executable is not present in the initramfs then snapshots cannot be automounted. The commit adds /usr/bin/env to the list of executables included in the initramfs image.
Motivation and Context
With zfs 0.6.4 our system booted without intervention when it copied the root filesystem image from a snapshot to memory. After upgrading to 0.7.1 (ubuntu daily ppa) this was no longer the case until /usr/bin/env was included in the initramfs image.
#5360
How Has This Been Tested?
We use a custom initramfs hook script which has
copy_exec /usr/bin/env. This is the equivalent in the master repository which we anticipate adopting in the near future.Types of changes
Checklist:
Signed-off-by.