Honor --with-mounthelperdir where applicable #6962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinatale2
suggested changes
Dec 14, 2017
|
Good catch @dinatale2, yes we should honor that. I'd forgotten it was added. |
|
@dinatale2 thanks, i had missed that. I'm kind of two minds about this: if i understand correctly Out of curiosity i just installed ZFS on a Gentoo box and the build system doesn't seem to be using |
|
@behlendorf i'll update the PR accordingly to honor |
loli10K
changed the title
loli10K
force-pushed
the
fix-dracut-mount.zfs
branch
from
65c79c8
to
8e90341
Compare
dinatale2
reviewed
Dec 17, 2017
| @@ -5,7 +5,7 @@ check() { | |||
| [ "${1}" = "-d" ] && return 0 | |||
|
|
|||
| # Verify the zfs tool chain | |||
| for tool in "@sbindir@/zpool" "@sbindir@/zfs" "@sbindir@/mount.zfs" ; do | |||
| for tool in "@sbindir@/zpool" "@sbindir@/zfs" "@mounthelperdir@/mount.zfs" ; do | |||
There was a problem hiding this comment.
I think you may need to add -e 's,@mounthelperdir\@,$(mounthelperdir),g' to the sed command in contrib/dracut/90zfs/Makefile.am.
There was a problem hiding this comment.
@dinatale2 you're right, thanks.
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
loli10K
force-pushed
the
fix-dracut-mount.zfs
branch
from
8e90341
to
b9927ec
Compare
dinatale2
approved these changes
Dec 17, 2017
behlendorf
approved these changes
Dec 17, 2017
Codecov Report
@@ Coverage Diff @@
## master #6962 +/- ##
==========================================
+ Coverage 75.17% 75.19% +0.01%
==========================================
Files 296 296
Lines 95453 95453
==========================================
+ Hits 71759 71772 +13
+ Misses 23694 23681 -13
Continue to review full report at Codecov.
|
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Jan 29, 2018
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#6962
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Feb 13, 2018
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#6962
Conan-Kudo
pushed a commit
to Conan-Kudo/zfs
that referenced
this pull request
Jan 17, 2019
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#6962 (cherry picked from commit e2d936e)
Conan-Kudo
pushed a commit
to Conan-Kudo/zfs
that referenced
this pull request
Jan 17, 2019
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#6962 (cherry picked from commit e2d936e) Signed-off-by: Neal Gompa <ngompa@datto.com> Requires-spl: spl-0.7-release
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 30, 2019
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#6962
tonyhutter
pushed a commit
that referenced
this pull request
Mar 4, 2019
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes #6962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiny fix:
mount.zfsis always installed in "/sbin", if ZFS is ./configure'd with a custom (or the default "/usr/local") prefix dracut can't find the mount helper binary.Motivation and Context
Custom ZFS builds may fail to mount filesystems.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.