Add libaio-devel BuildRequires #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zfs-test package needs a build requirement on the libaio-devel package. Without it ./configure will correctly determine that mmap_libaio cannot be built and it will be skipped. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#7821
gmelikov
approved these changes
Aug 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #7824 +/- ##
=========================================
- Coverage 78.42% 78.23% -0.2%
=========================================
Files 374 374
Lines 112907 112907
=========================================
- Hits 88548 88332 -216
- Misses 24359 24575 +216
Continue to review full report at Codecov.
|
|
@behlendorf do you want this in 0.7.10? |
|
@tonyhutter yes, that would be best. Thanks! |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 28, 2018
The zfs-test package needs a build requirement on the libaio-devel package. Without it ./configure will correctly determine that mmap_libaio cannot be built and it will be skipped. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#7821 Closes openzfs#7824
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 30, 2018
The zfs-test package needs a build requirement on the libaio-devel package. Without it ./configure will correctly determine that mmap_libaio cannot be built and it will be skipped. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#7821 Closes openzfs#7824
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 5, 2018
The zfs-test package needs a build requirement on the libaio-devel package. Without it ./configure will correctly determine that mmap_libaio cannot be built and it will be skipped. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#7821 Closes openzfs#7824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
zfs-testpackage should include all binaries needed to for a full ZTS run.Issue #7821
Description
The
zfs-testpackage needs a build requirement on thelibaio-develpackage. Without it ./configure will correctly determine thatmmap_libaiocannot be built and it will be skipped.How Has This Been Tested?
Locally build zfs-test package, verified
mmap_libaiois built and included.Types of changes
Checklist:
Signed-off-by.