Fix libaio-devel requirement for Debian-based distributions #7831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildRequires tags for "-devel" packages in the RPM spec file do not work when building on Debian-based distributions. Fix this issue by making this requirement conditional to RPM-based distributions. Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7831 +/- ##
==========================================
+ Coverage 78.3% 78.44% +0.13%
==========================================
Files 374 374
Lines 112907 112907
==========================================
+ Hits 88413 88568 +155
+ Misses 24494 24339 -155
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Aug 26, 2018
behlendorf
added
Status: Accepted
gmelikov
approved these changes
Aug 26, 2018
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 28, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not work when building on Debian-based distributions. Fix this issue by making this requirement conditional to RPM-based distributions. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#7829 Closes openzfs#7831
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 30, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not work when building on Debian-based distributions. Fix this issue by making this requirement conditional to RPM-based distributions. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#7829 Closes openzfs#7831
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 5, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not work when building on Debian-based distributions. Fix this issue by making this requirement conditional to RPM-based distributions. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#7829 Closes openzfs#7831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix #7829
EDIT: It's still not yet clear to me why the Debian9 builder did not catch this issue.
Description
BuildRequires tags for "-devel" packages in the RPM spec file do not work when building on Debian-based distributions.
Fix this issue by making this requirement conditional to RPM-based distributions.
How Has This Been Tested?
This patch is currently untested.
Types of changes
Checklist:
Signed-off-by.