Fix flake 8 style warnings (issue #7925) #7952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran zts-report.py and test-runner.py from ./tests/test-runner/bin/ through the 2to3 (https://docs.python.org/2/library/2to3.html). Checked the result, fixed: - 'maxint' -> 'maxsize' that 2to3 missed. - 'cmp=' parameter for a 'sorted()' with a 'key=' version. - try/except wrapping of configparser import as there are still python 2.7 systems that lack a compatibility shim Signed-off-by: Gregor Kopka <gregor@kopka.net> Closes openzfs#7925
13 tasks
Codecov Report
@@ Coverage Diff @@
## master #7952 +/- ##
==========================================
+ Coverage 78.49% 78.6% +0.11%
==========================================
Files 376 376
Lines 114030 114030
==========================================
+ Hits 89508 89634 +126
+ Misses 24522 24396 -126
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Sep 25, 2018
|
@GregorKopka are there any remaining concerns that this won't work with python 2.6? The CentOS 6 builder appears to be fine, but I wanted to double check. |
|
@behlendorf As I buried my last python 2.6 installation over half a decade ago I have no way to test them on an actual living interpreter - should you feel unsure you might have to ask someone who is either versed in necromancy or has access to a system with 2.6 to test it there. That being said, as the changes I made to make the scripts compatible with python 3 don't use any new constructs or language features, no external stuff (apart from the configparser module name) was touched and they run on the CentOS 6 builders... it should be fine. |
|
Since everything does work on the CentOS 6 builder, I'm good with this. |
13 tasks
GregorKopka
added a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
Ran zts-report.py and test-runner.py from ./tests/test-runner/bin/ through the 2to3 (https://docs.python.org/2/library/2to3.html). Checked the result, fixed: - 'maxint' -> 'maxsize' that 2to3 missed. - 'cmp=' parameter for a 'sorted()' with a 'key=' version. - try/except wrapping of configparser import as there are still python 2.7 systems that lack a compatibility shim Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Gregor Kopka <gregor@kopka.net> Closes openzfs#7925 Closes openzfs#7952
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 13, 2019
Ran zts-report.py and test-runner.py from ./tests/test-runner/bin/ through the 2to3 (https://docs.python.org/2/library/2to3.html). Checked the result, fixed: - 'maxint' -> 'maxsize' that 2to3 missed. - 'cmp=' parameter for a 'sorted()' with a 'key=' version. - try/except wrapping of configparser import as there are still python 2.7 systems that lack a compatibility shim Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Gregor Kopka <gregor@kopka.net> Closes openzfs#7925 Closes openzfs#7952
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 19, 2019
Ran zts-report.py and test-runner.py from ./tests/test-runner/bin/ through the 2to3 (https://docs.python.org/2/library/2to3.html). Checked the result, fixed: - 'maxint' -> 'maxsize' that 2to3 missed. - 'cmp=' parameter for a 'sorted()' with a 'key=' version. - try/except wrapping of configparser import as there are still python 2.7 systems that lack a compatibility shim Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Gregor Kopka <gregor@kopka.net> Closes openzfs#7925 Closes openzfs#7952
tonyhutter
pushed a commit
that referenced
this pull request
Mar 4, 2019
Ran zts-report.py and test-runner.py from ./tests/test-runner/bin/ through the 2to3 (https://docs.python.org/2/library/2to3.html). Checked the result, fixed: - 'maxint' -> 'maxsize' that 2to3 missed. - 'cmp=' parameter for a 'sorted()' with a 'key=' version. - try/except wrapping of configparser import as there are still python 2.7 systems that lack a compatibility shim Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Gregor Kopka <gregor@kopka.net> Closes #7925 Closes #7952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue #7925
Description
Ran zts-report.py and test-runner.py from ./tests/test-runner/bin/
through the 2to3 (https://docs.python.org/2/library/2to3.html).
Checked the result, fixed:
python 2.7 systems that lack a compatibility shim
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.