Prefix all refcount functions with zfs_ #7963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Codecov Report
@@ Coverage Diff @@
## master #7963 +/- ##
==========================================
- Coverage 78.64% 78.47% -0.18%
==========================================
Files 377 377
Lines 114014 114018 +4
==========================================
- Hits 89668 89475 -193
- Misses 24346 24543 +197
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Sep 27, 2018
ahrens
approved these changes
Sep 28, 2018
include/sys/refcount.h
Outdated
| int64_t refcount_count(zfs_refcount_t *rc); | ||
| void zfs_refcount_create(zfs_refcount_t *rc); | ||
| void zfs_refcount_create_untracked(zfs_refcount_t *rc); | ||
| void zfs_refcount_create_tracked(zfs_refcount_t *rc); |
There was a problem hiding this comment.
While you're here, if you'd like to remove the argument names (throughout this header file), that would be good too.
There was a problem hiding this comment.
Sure, I can do that. It will have to wait until afternoon though (in about 7 hours).
ahrens
added
Status: Accepted
Recent changes in the Linux kernel made it necessary to prefix the refcount_add() function with zfs_ due to a name collision. To bring the other functions in line with that and to avoid future collisions, prefix the other refcount functions as well. Signed-off-by: Tim Schumacher <timschumi@gmx.de>
ahrens
approved these changes
Sep 28, 2018
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Oct 31, 2018
Recent changes in the Linux kernel made it necessary to prefix the refcount_add() function with zfs_ due to a name collision. To bring the other functions in line with that and to avoid future collisions, prefix the other refcount functions as well. Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tim Schumacher <timschumi@gmx.de> Closes openzfs#7963
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 5, 2018
Recent changes in the Linux kernel made it necessary to prefix the refcount_add() function with zfs_ due to a name collision. To bring the other functions in line with that and to avoid future collisions, prefix the other refcount functions as well. Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tim Schumacher <timschumi@gmx.de> Closes openzfs#7963
tonyhutter
pushed a commit
that referenced
this pull request
Nov 13, 2018
Recent changes in the Linux kernel made it necessary to prefix the refcount_add() function with zfs_ due to a name collision. To bring the other functions in line with that and to avoid future collisions, prefix the other refcount functions as well. Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tim Schumacher <timschumi@gmx.de> Closes #7963
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
Recent changes in the Linux kernel made it necessary to prefix the refcount_add() function with zfs_ due to a name collision. To bring the other functions in line with that and to avoid future collisions, prefix the other refcount functions as well. Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tim Schumacher <timschumi@gmx.de> Closes openzfs#7963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This brings refcount function naming in line with the zfs_refcount_add() method, which was
changed for Linux 4.19 compatibility. It should also prevent future collisions in case any other
functions get added.
Description
Prefixed every function definition and call with zfs_ and reformatted lines that were longer
than 80 chars after that.
How Has This Been Tested?
Compiled and tested with Linux 4.18.8 and 4.19.0-rc5. Ran zloop for about a hour and a half.
Types of changes
Checklist:
Signed-off-by.