Define timestruc_t for Lustre compatibility #8014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Oct 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #8014 +/- ##
==========================================
- Coverage 78.55% 78.33% -0.22%
==========================================
Files 377 377
Lines 114165 114213 +48
==========================================
- Hits 89678 89466 -212
- Misses 24487 24747 +260
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
behlendorf
reviewed
Oct 12, 2018
include/spl/sys/time.h
Outdated
| @@ -66,6 +66,9 @@ typedef struct timespec64 inode_timespec_t; | |||
| typedef struct timespec inode_timespec_t; | |||
| #endif | |||
|
|
|||
| /* Include for Lustre compatibility */ | |||
| #define timestruc_t inode_timespec_t | |||
There was a problem hiding this comment.
nit: there's a small cstyle issue.
There was a problem hiding this comment.
Thanks, fixed in my latest push
Lustre 2.8 (and possibly other versions) are still using timestruc_t, which was removed in spl-0.7.10 in favor of inode_timespec_t. Add in a backwards compatibility #define for timestruc_t so that Lustre builds. Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter
force-pushed
the
timestruct_lustre
branch
from
74a90d6
to
94b7768
Compare
ghfields
pushed a commit
to ghfields/zfs
that referenced
this pull request
Oct 29, 2018
Lustre 2.8 (and possibly other versions) are still using timestruc_t, which was removed in spl-0.7.10 in favor of inode_timespec_t. Add in a backwards compatibility #define for timestruc_t so that Lustre builds. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#8014
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
Lustre 2.8 (and possibly other versions) are still using timestruc_t, which was removed in spl-0.7.10 in favor of inode_timespec_t. Add in a backwards compatibility #define for timestruc_t so that Lustre builds. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#8014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Allow lustre to build against zfs
Description
Lustre 2.8 (and possibly other versions) are still using
timestruc_t, which was removed inspl-0.7.10in favour ofinode_timespec_t. Add in a backwards compatibility#definefortimestruc_tso that Lustre builds.Signed-off-by: Tony Hutter hutter2@llnl.gov
How Has This Been Tested?
Verified lustre built. This patch has been in the LLNL ZFS branch for the last three weeks (https://github.com/LLNL/zfs/releases/tag/zfs-0.7.11-2llnl).
Types of changes
Checklist:
Signed-off-by.