Fix flake8 "invalid escape sequence 'x'" warning #8056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwk404
approved these changes
Oct 24, 2018
cmd/arcstat/arcstat.py
Outdated
| @@ -112,7 +112,7 @@ | |||
| d = {} | |||
| out = None | |||
| kstat = None | |||
| float_pobj = re.compile("^[0-9]+(\.[0-9]+)?$") | |||
| float_pobj = re.compile(r'^[0-9]+(\.[0-9]+)?$') | |||
There was a problem hiding this comment.
I think this is dead code and can be removed.
There was a problem hiding this comment.
Good catch, I've removed it.
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html As of Python 3.6, a backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. Note 'float_pobj' was simply removed from arcstat.py since it was entirely unused. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
behlendorf
added
Status: Accepted
|
@behlendorf I live in a different timezone, please give me enough time to wake up. Looks good though. While looking at arcstat.py: in case you're interested in GregorKopka@cbba76d please drop me a line, if not I'll make a pull that only fixes the |
|
@GregorKopka sorry about that. Normally, I'd have let this sit for a day or two before merging to get feedback, but since it was a tiny change, and because it was causing the style builder to needlessly fail for every PR I rushed it a bit. It would be great if you could open a PR with that fix. |
ghfields
pushed a commit
to ghfields/zfs
that referenced
this pull request
Oct 29, 2018
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html As of Python 3.6, a backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. Note 'float_pobj' was simply removed from arcstat.py since it was entirely unused. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8056
BrainSlayer
pushed a commit
to BrainSlayer/zfs
that referenced
this pull request
Nov 4, 2018
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html As of Python 3.6, a backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. Note 'float_pobj' was simply removed from arcstat.py since it was entirely unused. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8056
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 6, 2018
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html As of Python 3.6, a backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. Note 'float_pobj' was simply removed from arcstat.py since it was entirely unused. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8056
tonyhutter
pushed a commit
that referenced
this pull request
Nov 13, 2018
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html As of Python 3.6, a backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. Note 'float_pobj' was simply removed from arcstat.py since it was entirely unused. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #8056
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html As of Python 3.6, a backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. Note 'float_pobj' was simply removed from arcstat.py since it was entirely unused. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
New warnings reported by updated version of
flake8.http://build.zfsonlinux.org/builders/Ubuntu%2017.10%20x86_64%20%28STYLE%29/builds/8367/steps/shell_2/logs/stdio
Description
From, https://lintlyci.github.io/Flake8Rules/rules/W605.html
As of Python 3.6, a backslash-character pair that is not a valid
escape sequence now generates a DeprecationWarning. Although this
will eventually become a SyntaxError, that will not be for several
Python releases.
How Has This Been Tested?
Installed
flake8-3.6.0, and checked style. No warnings reported with the change.@GregorKopka would you mind reviewing this.
Types of changes
Checklist:
Signed-off-by.