Linux 4.20 compat: current_kernel_time() #8074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit torvalds/linux@976516404 removed the current_kernel_time() function (and several others). All callers are expected to use current_kernel_time64(). Update the gethrestime_sec() wrapper accordingly. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
tonyhutter
approved these changes
Oct 30, 2018
|
fwiw, I have two machines running 4.19.0 and they compiled and run okay. I can't see what version they added this to. |
|
Looks like this is post 4.19: |
Codecov Report
@@ Coverage Diff @@
## master #8074 +/- ##
==========================================
+ Coverage 78.39% 78.43% +0.03%
==========================================
Files 377 377
Lines 114494 114494
==========================================
+ Hits 89763 89804 +41
+ Misses 24731 24690 -41
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
behlendorf
changed the title
satmandu
added a commit
to satmandu/zfs
that referenced
this pull request
Dec 26, 2018
While openzfs/spl@cd1b28e fixed the 4.20 current_kernel_time issues in spl as per openzfs#8074 in .07.x, current_kernel_time is still being used inside zpios-ctl.h in 0.7.x. I believe this may fix this issue in 0.7.x to allow it to compile successfully for kernel 4.2.0.
9 tasks
|
@tonyhutter FYI there is one more issue with getting 0.7.x to compile for Linux kernel 4.20. |
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
Commit torvalds/linux@976516404 removed the current_kernel_time() function (and several others). All callers are expected to use current_kernel_time64(). Update the gethrestime_sec() wrapper accordingly. Reviewed-by: Olaf Faaland <faaland1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Compatibility with the latest kernels. See the following build failure.
http://build.zfsonlinux.org/builders/Kernel.org%20Built-in%20x86_64%20%28BUILD%29/builds/23324
Description
Commit torvalds/linux@976516404 removed the current_kernel_time()
function (and several others). All callers are expected to use
current_kernel_time64(). Update the gethrestime_sec() wrapper
accordingly.
How Has This Been Tested?
Locally compiled.
Types of changes
Checklist:
Signed-off-by.