Add BuildRequires: gcc, make, elfutils-libelf-devel #8102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyhutter
added
the
Type: Building
tonyhutter
force-pushed
the
buildrequires
branch
from
bdb4ab6
to
1e041da
Compare
behlendorf
approved these changes
Nov 6, 2018
|
@Conan-Kudo would you mind reviewing this. |
Conan-Kudo
suggested changes
Nov 7, 2018
| @@ -52,6 +52,8 @@ URL: http://zfsonlinux.org/ | |||
| Source0: %{module}-%{version}.tar.gz | |||
| Source10: kmodtool | |||
| BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id} -u -n) | |||
| BuildRequires: gcc, make | |||
| BuildRequires: elfutils-libelf-devel | |||
There was a problem hiding this comment.
You'll want to wrap these BuildRequires in a conditional, or otherwise it'll fail package builds for Debian.
So, this should be:
%if 0%{?rhel}%{?fedora}
BuildRequires: gcc, make
BuildRequires: elfutils-libelf-devel
%endif
rpm/generic/zfs.spec.in
Outdated
| @@ -92,6 +92,7 @@ Obsoletes: spl | |||
| # those on either side would conflict with all available documentation. | |||
| Conflicts: zfs-fuse | |||
|
|
|||
| BuildRequires: gcc, make | |||
There was a problem hiding this comment.
This needs to be in the conditional that's the line below for to avoid Debian/Ubuntu breakage.
Codecov Report
@@ Coverage Diff @@
## master #8102 +/- ##
==========================================
+ Coverage 78.44% 78.49% +0.05%
==========================================
Files 381 377 -4
Lines 114550 114518 -32
==========================================
+ Hits 89854 89892 +38
+ Misses 24696 24626 -70
Continue to review full report at Codecov.
|
tonyhutter
force-pushed
the
buildrequires
branch
from
1e041da
to
3ef21d7
Compare
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel into our spec files. gcc has been a packaging requirement for awhile now: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B These additional BuildRequires allow us to mock build in Fedora 29. Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#8095
tonyhutter
force-pushed
the
buildrequires
branch
from
3ef21d7
to
c6c30d3
Compare
|
@Conan-Kudo my latest push has your fixes included. |
Conan-Kudo
approved these changes
Nov 7, 2018
tonyhutter
added a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 7, 2018
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel into our spec files. gcc has been a packaging requirement for awhile now: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B These additional BuildRequires allow us to mock build in Fedora 29. Reviewed-by: Neal Gompa <ngompa@datto.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#8095 Closes openzfs#8102
behlendorf
added
Status: Accepted
tonyhutter
added a commit
that referenced
this pull request
Nov 13, 2018
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel into our spec files. gcc has been a packaging requirement for awhile now: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B These additional BuildRequires allow us to mock build in Fedora 29. Reviewed-by: Neal Gompa <ngompa@datto.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes #8095 Closes #8102
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel into our spec files. gcc has been a packaging requirement for awhile now: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B These additional BuildRequires allow us to mock build in Fedora 29. Reviewed-by: Neal Gompa <ngompa@datto.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#8095 Closes openzfs#8102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds a
BuildRequiresforgcc,make, andelfutils-libelf-develinto our spec files. gcc has been a packaging requirement for awhile now:https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
These additional BuildRequires allow us to mock build in Fedora 29.
Closes #8095
Description
Add BuildRequires: gcc, make, elfutils-libelf-devel
How Has This Been Tested?
Did a mock build in Fedora 29. Without the patch, I'd see:
configure: error: no acceptable C compiler found in $PATHor
configure: checking whether modules can be built... noWith the patch, they correctly built.
Types of changes
Checklist:
Signed-off-by.