Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable pyzfs explicity in spec #8179

Closed
wants to merge 1 commit into from

Conversation

utopiabound
Copy link
Contributor

Add --with/without pyzfs to rpm build

Explicitly enable or disable pyzfs during configure based on
what will be packaged. Configuration test should not make
packaging fail if python-cffi is installed.

Partially Addresses Issue #7882

Signed-off-by: Nathaniel Clark nathaniel.clark@misrule.us

Motivation and Context

Explicitly enable or disable pyzfs during configure based on what will be packaged. Configuration test should not make packaging fail if python-cffi is installed.

Description

If building pyzfs package, enable pyzfs in configured, and disable if not building pyzfs.

How Has This Been Tested?

Built locally on CentOS 7.4 with and without pyzfs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Add --with/without pyzfs to rpm build

Explicitly enable or disable pyzfs during configure based on
what will be packaged.  Configuration test should not make
packaging fail if python-cffi is installed.

Partially Addresses Issue 7882

Signed-off-by: Nathaniel Clark <nathaniel.clark@misrule.us>
@loli10K
Copy link
Contributor

loli10K commented Dec 4, 2018

I think a more comprehensive approach is already being proposed in #8096

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #8179 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8179      +/-   ##
==========================================
+ Coverage   78.46%   78.48%   +0.02%     
==========================================
  Files         378      378              
  Lines      114826   114765      -61     
==========================================
- Hits        90095    90079      -16     
+ Misses      24731    24686      -45
Flag Coverage Δ
#kernel 78.78% <ø> (-0.12%) ⬇️
#user 67.38% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5eea0a...205916d. Read the comment docs.

@utopiabound
Copy link
Contributor Author

Given #8096 is a blocker for 0.8.0, I'll close this

@utopiabound utopiabound closed this Dec 5, 2018
@utopiabound utopiabound deleted the pyzfs-spec branch December 5, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants