Use autoconf variable for C preprocessor #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build when cross-compiling, where the preprocessor might be prefixed. Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
No need - I added it to the 0.7.13 patchlist. |
|
There is more needed for 0.7, though, because a similar cpp invocation is used to detect the SPL version. This check no longer exists in master since the SPL was merged. |
|
@lopsided98 ok, that's fine then if you want to do an 0.7 PR as well. |
behlendorf
added
Type: Building
tonyhutter
approved these changes
Dec 4, 2018
This was referenced Dec 5, 2018
|
See #8183 and openzfs/spl#711. |
behlendorf
added
Status: Accepted
Codecov Report
@@ Coverage Diff @@
## master #8180 +/- ##
=========================================
- Coverage 78.46% 78.36% -0.1%
=========================================
Files 378 378
Lines 114826 114765 -61
=========================================
- Hits 90095 89933 -162
- Misses 24731 24832 +101
Continue to review full report at Codecov.
|
gmelikov
approved these changes
Dec 5, 2018
GregorKopka
pushed a commit
to GregorKopka/zfs
that referenced
this pull request
Jan 7, 2019
This fixes the build when cross-compiling, where the preprocessor might be prefixed. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Closes openzfs#8180
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 30, 2019
This fixes the build when cross-compiling, where the preprocessor might be prefixed. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Closes openzfs#8180
tonyhutter
pushed a commit
that referenced
this pull request
Mar 4, 2019
This fixes the build when cross-compiling, where the preprocessor might be prefixed. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Closes #8180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ZFS uses a hardcoded name for the C preprocessor when detecting the kernel version, which may not be available when cross-compiling in an environment without a native compiler.
Description
This PR changes the command to use the correct prefixed preprocessor that was found with autoconf.
The trailing dash is needed because autoconf will normally set
CPPtogcc -E, which requires-to read from stdin. This is not necessary, but harmless, ifCPPis set tocpp.I have a similar fix for 0.7; should I open a PR against the
zfs-0.7-releasebranch?How Has This Been Tested?
I built ZFS with this patch, both natively for x86_64 and cross compiled for aarch64.
Types of changes
Checklist:
Signed-off-by.