zfs.8 uses wrong snapshot names in Example 15

[bengentil]

Motivation and Context

in Example 15 of zfs.8 manual the snapshot names are wrong:

     Example 15 Performing a Rolling Snapshot
       The following example shows how to maintain a history of snapshots with a consistent naming
       scheme.  To keep a week's worth of snapshots, the user destroys the oldest snapshot, renames
       the remaining snapshots, and then creates a new snapshot, as follows:

       # zfs destroy -r pool/users@7daysago
       # zfs rename -r pool/users@6daysago @7daysago
       # zfs rename -r pool/users@5daysago @6daysago
       # zfs rename -r pool/users@yesterday @5daysago    <<<<
       # zfs rename -r pool/users@yesterday @4daysago    <<<<
       # zfs rename -r pool/users@yesterday @3daysago    <<<<
       # zfs rename -r pool/users@yesterday @2daysago
       # zfs rename -r pool/users@today @yesterday
       # zfs snapshot -r pool/users@today

Description

It should be

       # zfs rename -r pool/users@4daysago @5daysago
       # zfs rename -r pool/users@3daysago @4daysago
       # zfs rename -r pool/users@2daysago @3daysago

It's already fixed on FreeBSD: https://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/cmd/zfs/zfs.8?r1=239217&r2=239216&pathrev=239217
and a similar fix has been proposed to illumos https://www.illumos.org/issues/9623.

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.

[bunder2015]

LGTM, thanks for catching this.

[codecov]

Codecov Report

Merging #8241 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8241      +/-   ##
==========================================
+ Coverage   78.57%    78.6%   +0.03%     
==========================================
  Files         379      379              
  Lines      114924   114924              
==========================================
+ Hits        90299    90338      +39     
+ Misses      24625    24586      -39

Flag	Coverage Δ
#kernel	78.94% <ø> (-0.04%)	⬇️
#user	67.42% <ø> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8e441...76dabbb. Read the comment docs.