Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dkms: Enable debuginfo option to be set with zfs sysconfig file #8304

Merged
merged 1 commit into from Jan 18, 2019
Merged

dkms: Enable debuginfo option to be set with zfs sysconfig file #8304

merged 1 commit into from Jan 18, 2019

Conversation

Conan-Kudo
Copy link
Contributor

@Conan-Kudo Conan-Kudo commented Jan 17, 2019 •
edited

Motivation and Context

On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Description

Added ZFS_DKMS_ENABLE_DEBUGINFO flag support to the dkms.mkconf script.

How Has This Been Tested?

I built the tree with this change and added the ZFS_DKMS_ENABLE_DEBUGINFO=yes flag to /etc/sysconfig/zfs and verified it forced debuginfo to be generated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@Conan-Kudo
dkms: Enable debuginfo option to be set with zfs sysconfig file
a9afa33 
On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Co-authored-by: Neal Gompa <ngompa@datto.com>
Co-authored-by: Simon Watson <swatson@datto.com>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Simon Watson <swatson@datto.com>
@tonyhutter tonyhutter added the Type: Building Indicates an issue related to building binaries label Jan 17, 2019
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #8304 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8304      +/-   ##
==========================================
+ Coverage   78.44%   78.44%   +<.01%     
==========================================
  Files         380      380              
  Lines      115675   115675              
==========================================
+ Hits        90740    90745       +5     
+ Misses      24935    24930       -5
Flag Coverage Δ
#kernel 78.92% <ø> (-0.03%) ⬇️
#user 67.17% <ø> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419ba59...a9afa33. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 18, 2019
@behlendorf behlendorf merged commit e45c173 into openzfs:master Jan 18, 2019
@Conan-Kudo Conan-Kudo deleted the allow-debuginfo-dkms-build branch January 18, 2019 18:22
Conan-Kudo added a commit to Conan-Kudo/zfs that referenced this pull request Jan 23, 2019
@Conan-Kudo
dkms: Enable debuginfo option to be set with zfs sysconfig file
2fb8eb7 
On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Neal Gompa <ngompa@datto.com>
Co-authored-by: Simon Watson <swatson@datto.com>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Simon Watson <swatson@datto.com>
Closes openzfs#8304

(cherry picked from commit e45c173)

Signed-off-by: Neal Gompa <ngompa@datto.com>
Conan-Kudo added a commit to Conan-Kudo/zfs that referenced this pull request Jan 23, 2019
@Conan-Kudo
dkms: Allow debuginfo option to be set in sysconfig file
c128a09 
On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Neal Gompa <ngompa@datto.com>
Co-authored-by: Simon Watson <swatson@datto.com>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Simon Watson <swatson@datto.com>
Closes openzfs#8304

(cherry picked from commit e45c173)

Signed-off-by: Neal Gompa <ngompa@datto.com>
@tonyhutter tonyhutter added this to To do in 0.7.13 Jan 24, 2019
@tonyhutter tonyhutter moved this from To do to In progress in 0.7.13 Jan 28, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 30, 2019
@Conan-Kudo @tonyhutter
dkms: Enable debuginfo option to be set with zfs sysconfig file
20267a0 
On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Neal Gompa <ngompa@datto.com>
Co-authored-by: Simon Watson <swatson@datto.com>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Simon Watson <swatson@datto.com>
Closes openzfs#8304
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 12, 2019
@Conan-Kudo @tonyhutter
dkms: Enable debuginfo option to be set with zfs sysconfig file
d9330a9 
On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Neal Gompa <ngompa@datto.com>
Co-authored-by: Simon Watson <swatson@datto.com>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Simon Watson <swatson@datto.com>
Closes openzfs#8304
tonyhutter pushed a commit that referenced this pull request Mar 4, 2019
@Conan-Kudo @tonyhutter
dkms: Enable debuginfo option to be set with zfs sysconfig file
44f4638 
On some Linux distributions, the kernel module build will not
default to building with debuginfo symbols, which can make it
difficult for debugging and testing.

For this case, we provide a flag to override the build to force
debuginfo to be produced for the kernel module build.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Neal Gompa <ngompa@datto.com>
Co-authored-by: Simon Watson <swatson@datto.com>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Simon Watson <swatson@datto.com>
Closes #8304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
No open projects
0.7.13
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Conan-Kudo @behlendorf @tonyhutter