Clarify and improve encryption documentation#8652
Merged
behlendorf merged 1 commit intoopenzfs:masterfrom Apr 25, 2019
Merged
Conversation
Member
Author
|
@tcaputi Am I correct that properties (especially user properties) are not encrypted? |
tcaputi
approved these changes
Apr 22, 2019
Contributor
tcaputi
left a comment
tcaputi
left a comment
There was a problem hiding this comment.
You are correct about properties. This LGTM, with 1 small suggestion.
- Remove the language that "all user data" is encrypted. This is to avoid misunderstandings or arguments about what is "user data", especially in light of "user properties". - Document that properties are unencrypted. - Document that snapshot names are unencrypted. - For consistency with the rest of the zfs.8 man page, use "ZFS" as the generic noun, not (bolded) "zfs". The latter refers to the command. Likewise, use "ZFS" instead of "the kernel module". - Give "a passphrase" as an example of a "user's key". Signed-off-by: Richard Laager <rlaager@wiktel.com>
rlaager
force-pushed
the
encryption-limitations
branch
from
b997ff4 to
128515f
Compare
Codecov Report
@@ Coverage Diff @@
## master #8652 +/- ##
==========================================
+ Coverage 78.69% 78.77% +0.07%
==========================================
Files 381 381
Lines 117578 117578
==========================================
+ Hits 92527 92618 +91
+ Misses 25051 24960 -91
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Apr 23, 2019
behlendorf
added
Status: Accepted
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I've been reviewing documentation, especially that related to new features like encryption. I have a tendency to edit everything under my cursor. ;)
Description
How Has This Been Tested?
I reviewed the changes with
man.Types of changes
Checklist:
Signed-off-by.