Revert "Report holes when there are only metadata changes" #8834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec4f9b8 which introduced a narrow race which can lead to lseek(, SEEK_DATA) incorrectly returning ENXIO. Resolve the issue by revering this change to restore the previous behavior which depends solely on checking the dirty list. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Codecov Report
@@ Coverage Diff @@
## master #8834 +/- ##
==========================================
- Coverage 78.7% 78.65% -0.05%
==========================================
Files 382 382
Lines 117802 117792 -10
==========================================
- Hits 92712 92651 -61
- Misses 25090 25141 +51
Continue to review full report at Codecov.
|
ikozhukhov
approved these changes
May 30, 2019
There was a problem hiding this comment.
i have issues on DilOS with it and reverted:
https://bitbucket.org/dilos/dilos-illumos/commits/818bb9a69906476487c4acd0bac308152e8e0fc1
i thought it was my fault with port to dilos.
behlendorf
added
Status: Accepted
behlendorf
added a commit
that referenced
this pull request
Jun 7, 2019
This reverts commit ec4f9b8 which introduced a narrow race which can lead to lseek(, SEEK_DATA) incorrectly returning ENXIO. Resolve the issue by revering this change to restore the previous behavior which depends solely on checking the dirty list. Reviewed-by: Olaf Faaland <faaland1@llnl.gov> Reviewed-by: Igor Kozhukhov <igor@dilos.org> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #8816 Closes #8834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue #8816.
Description
This reverts commit ec4f9b8 which introduced a narrow race which can lead to lseek(, SEEK_DATA) incorrectly returning ENXIO. Resolve the issue by revering this change to restore the previous behavior which depends solely on checking the dirty list.
How Has This Been Tested?
The test case provided in #8816 was able to consistently reproduce this issue. After reverting the commit the problem could no longer be reproduced. Additionally, the issue was first observed when running portage on gentoo and reverting the commit resolved the issue as expected.
Types of changes
Checklist:
Signed-off-by.