Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out-of-tree build failures #8943

Merged
merged 1 commit into from Jun 24, 2019
Merged

Fix out-of-tree build failures #8943

merged 1 commit into from Jun 24, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #8921.

Description

Resolve the incorrect use of srcdir and builddir references for various files
in the build system. These have crept in over time and went unnoticed because
when building in the top level directory srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

How Has This Been Tested?

Locally compiled user and kernel components in a subdirectory named obj.
Verify that make dist, make install, and make rpms all worked as intended.

mkdir obj
cd obj
../configure
make -s

Pending a full CI run to test all platforms. My testing was done on CentOS 7.
Currently, the CI does not test subdirectory compilation but adding such a
builder would help us prevent this in the future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing labels Jun 21, 2019
@behlendorf
Fix out-of-tree build failures
641af45 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8921
@codecov
Copy link

codecov bot commented Jun 22, 2019 •
edited

Codecov Report

Merging #8943 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8943      +/-   ##
==========================================
+ Coverage   78.48%   78.54%   +0.05%     
==========================================
  Files         388      388              
  Lines      120013   120011       -2     
==========================================
+ Hits        94197    94258      +61     
+ Misses      25816    25753      -63
Flag Coverage Δ
#kernel 79.43% <ø> (-0.03%) ⬇️
#user 66.11% <ø> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a370182...641af45. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 24, 2019
@behlendorf behlendorf merged commit 8f12a4f into openzfs:master Jun 24, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@behlendorf @tonyhutter
Fix out-of-tree build failures
69bf53e 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8921
Closes openzfs#8943
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@behlendorf @tonyhutter
Fix out-of-tree build failures
95090f4 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8921
Closes openzfs#8943
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@behlendorf @tonyhutter
Fix out-of-tree build failures
a9c451f 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8921
Closes openzfs#8943
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@behlendorf @tonyhutter
Fix out-of-tree build failures
62da467 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8921
Closes openzfs#8943
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@behlendorf @tonyhutter
Fix out-of-tree build failures
b0d0528 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8921
Closes openzfs#8943
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@behlendorf @tonyhutter
Fix out-of-tree build failures
cc7fe8a 
Resolve the incorrect use of srcdir and builddir references for
various files in the build system.  These have crept in over time
and went unnoticed because when building in the top level directory
srcdir and builddir are identical.

With this change it's again possible to build in a subdirectory.

    $ mkdir obj
    $ cd obj
    $ ../configure
    $ make

Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #8921
Closes #8943
@behlendorf behlendorf deleted the issue-8921 branch April 19, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loli10K loli10K loli10K approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

@don-brady don-brady don-brady approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@behlendorf @loli10K @tonyhutter @don-brady