Fix typos in tests/ #9244
Merged
Fix typos in tests/ #9244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Aug 29, 2019
tests/zfs-tests/tests/functional/projectquota/projectquota_004_neg.ksh
Outdated
Show resolved
Hide resolved
ghost
suggested changes
Aug 29, 2019
tests/zfs-tests/tests/functional/projectquota/projectquota_004_neg.ksh
Outdated
Show resolved
Hide resolved
ghost
approved these changes
Aug 29, 2019
rlaager
reviewed
Aug 29, 2019
| @@ -62,7 +62,7 @@ for prj in "${no_prjs[@]}"; do | |||
| log_mustnot zfs set projectquota@$prj=100m $QFS | |||
| done | |||
|
|
|||
| log_note "can set all numberic id even that id is not existed" | |||
| log_note "can set all numeric id even if that id is nonexistent" | |||
There was a problem hiding this comment.
This is fine. One other idea would be "can set all numeric id even if that id does not exist"
rlaager
approved these changes
Aug 29, 2019
rlaager
suggested changes
Aug 31, 2019
Thanks a lot for patch review to @freqlabs Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Done! Thanks |
Codecov Report
@@ Coverage Diff @@
## master #9244 +/- ##
==========================================
- Coverage 79.31% 76.06% -3.26%
==========================================
Files 400 383 -17
Lines 122034 120613 -1421
==========================================
- Hits 96792 91739 -5053
- Misses 25242 28874 +3632
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Sep 3, 2019
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#9244
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#9244
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes #9244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.