Refactor libzfs_error_init newlines #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the trailing newlines from the error message strings to the format strings to more closely match the other error messages. Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
behlendorf
approved these changes
Sep 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #9330 +/- ##
==========================================
+ Coverage 79.02% 79.05% +0.03%
==========================================
Files 401 401
Lines 122469 122469
==========================================
+ Hits 96777 96823 +46
+ Misses 25692 25646 -46
Continue to review full report at Codecov.
|
gmelikov
approved these changes
Sep 17, 2019
behlendorf
added
Status: Accepted
ghost
deleted the
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
Move the trailing newlines from the error message strings to the format strings to more closely match the other error messages. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9330
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
Move the trailing newlines from the error message strings to the format strings to more closely match the other error messages. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9330
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Move the trailing newlines from the error message strings to the format strings to more closely match the other error messages. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes #9330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
All other libzfs_error_* functions that return an error message do not include a trailing newline. Formatting is handled by the caller. This is also the convention outside of libzfs, for example
strerror(3).Description
Move the trailing newlines from the error message strings to the callers to more closely match the other error messages.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.