Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase allowed 'special_small_blocks' maximum value #9355

Merged
merged 1 commit into from Dec 3, 2019
Merged

Increase allowed 'special_small_blocks' maximum value #9355

merged 1 commit into from Dec 3, 2019
+17 −7

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #9131.

Description

There may be circumstances where it's desirable that all blocks
in a specified dataset be stored on the special device. Relax
the artificial 128K limit and allow the special_small_blocks
property to be set up to 1M. When blocks >1MB have been enabled
via the zfs_max_recordsize module option, this limit is increased
accordingly.

How Has This Been Tested?

Verified that zfs set special_small_blocks=1M works correctly when
the allocation classes feature is enabled. Additionally, verified the limit
can be increased up to 16M when zfs_max_recordsize in increased.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 24, 2019
@behlendorf behlendorf mentioned this pull request Sep 24, 2019
Closed
Mic92 pushed a commit to Mic92/zfs that referenced this pull request Sep 25, 2019
@behlendorf
Use signed types to prevent subtraction overflow
73d7820 
The difference between the sizes could be positive or negative. Leaving
the types as unsigned means the result overflows when the difference is
negative and removing the labs() means we'll have introduced a bug. The
subtraction results in the correct value when the unsigned integer is
interpreted as a signed integer by labs().

Clang doesn't see that we're doing a subtraction and abusing the types.
It sees the result of the subtraction, an unsigned value, being passed
to an absolute value function and emits a warning which we treat as an
error.

Reviewed by: Youzhong Yang <youzhong@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#9355
Ornias1993
Ornias1993 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@Ornias1993 Ornias1993 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR could use some review love, it's simple/clear and should be relatively quick to merge and review.

@Ornias1993
Copy link
Contributor

Test failures seem to me to be totally unrelated to this PR... But someone else could be beter suited to review those.

don-brady
don-brady reviewed Nov 13, 2019
View reviewed changes
lib/libzfs/libzfs_dataset.c Show resolved Hide resolved
lib/libzfs/libzfs_dataset.c Show resolved Hide resolved
@behlendorf
Increase allowed 'special_small_blocks' maximum value
3ef695c 
There may be circumstances where it's desirable that all blocks
in a specified dataset be stored on the special device.  Relax
the artificial 128K limit and allow the special_small_blocks
property to be set up to 1M.  When blocks >1MB have been enabled
via the zfs_max_recordsize module option, this limit is increased
accordingly.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#9131
@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited

Codecov Report

Merging #9355 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9355      +/-   ##
==========================================
- Coverage   79.11%   79.04%   -0.07%     
==========================================
  Files         419      419              
  Lines      123704   123708       +4     
==========================================
- Hits        97870    97789      -81     
- Misses      25834    25919      +85
Flag Coverage Δ
#kernel 79.7% <ø> (-0.03%) ⬇️
#user 66.63% <100%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8221bcf...3ef695c. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 2, 2019
@behlendorf behlendorf merged commit 624222a into openzfs:master Dec 3, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
@tonyhutter
Use signed types to prevent subtraction overflow
eceb327 
The difference between the sizes could be positive or negative. Leaving
the types as unsigned means the result overflows when the difference is
negative and removing the labs() means we'll have introduced a bug. The
subtraction results in the correct value when the unsigned integer is
interpreted as a signed integer by labs().

Clang doesn't see that we're doing a subtraction and abusing the types.
It sees the result of the subtraction, an unsigned value, being passed
to an absolute value function and emits a warning which we treat as an
error.

Reviewed by: Youzhong Yang <youzhong@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#9355
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
@behlendorf @tonyhutter
Increase allowed 'special_small_blocks' maximum value
7b7dbdb 
There may be circumstances where it's desirable that all blocks
in a specified dataset be stored on the special device.  Relax
the artificial 128K limit and allow the special_small_blocks
property to be set up to 1M.  When blocks >1MB have been enabled
via the zfs_max_recordsize module option, this limit is increased
accordingly.

Reviewed-by: Don Brady <don.brady@delphix.com>
Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9131
Closes openzfs#9355
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@tonyhutter
Use signed types to prevent subtraction overflow
49f7f24 
The difference between the sizes could be positive or negative. Leaving
the types as unsigned means the result overflows when the difference is
negative and removing the labs() means we'll have introduced a bug. The
subtraction results in the correct value when the unsigned integer is
interpreted as a signed integer by labs().

Clang doesn't see that we're doing a subtraction and abusing the types.
It sees the result of the subtraction, an unsigned value, being passed
to an absolute value function and emits a warning which we treat as an
error.

Reviewed by: Youzhong Yang <youzhong@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#9355
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@behlendorf @tonyhutter
Increase allowed 'special_small_blocks' maximum value
44bc323 
There may be circumstances where it's desirable that all blocks
in a specified dataset be stored on the special device.  Relax
the artificial 128K limit and allow the special_small_blocks
property to be set up to 1M.  When blocks >1MB have been enabled
via the zfs_max_recordsize module option, this limit is increased
accordingly.

Reviewed-by: Don Brady <don.brady@delphix.com>
Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9131
Closes openzfs#9355
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@tonyhutter
Use signed types to prevent subtraction overflow
8498a2f 
The difference between the sizes could be positive or negative. Leaving
the types as unsigned means the result overflows when the difference is
negative and removing the labs() means we'll have introduced a bug. The
subtraction results in the correct value when the unsigned integer is
interpreted as a signed integer by labs().

Clang doesn't see that we're doing a subtraction and abusing the types.
It sees the result of the subtraction, an unsigned value, being passed
to an absolute value function and emits a warning which we treat as an
error.

Reviewed by: Youzhong Yang <youzhong@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes #9355
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@behlendorf @tonyhutter
Increase allowed 'special_small_blocks' maximum value
9cf46dd 
There may be circumstances where it's desirable that all blocks
in a specified dataset be stored on the special device.  Relax
the artificial 128K limit and allow the special_small_blocks
property to be set up to 1M.  When blocks >1MB have been enabled
via the zfs_max_recordsize module option, this limit is increased
accordingly.

Reviewed-by: Don Brady <don.brady@delphix.com>
Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9131
Closes #9355
@behlendorf behlendorf deleted the issue-9131 branch April 19, 2021 19:24
ProxBot pushed a commit to proxmox/pve-docs that referenced this pull request Sep 16, 2022
@foxmox @ThomasLamprecht
zfs: special device: update maximum for special_small_blocks
9deec2e 
In ZFS 0.8.3, the limit was increased to 1M [0][1].

[0] https://github.com/openzfs/zfs/releases/tag/zfs-0.8.3
[1] openzfs/zfs#9355

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ornias1993 Ornias1993 Ornias1993 approved these changes

@don-brady don-brady don-brady approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@behlendorf @Ornias1993 @don-brady