Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix zpool_status_-s #9451

Merged
merged 1 commit into from Oct 11, 2019
Merged

ZTS: Fix zpool_status_-s #9451

merged 1 commit into from Oct 11, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Observed ZTS failures of zpool_status_-s test case.

Description

After commit 5e74ac5 which split and reordered the run files the
zpool_status_-s test began failing. The new ordering placed
the test after a previous test which used zpool replace to replace
a disk but did not clear its label. This resulted the next test,
zpool_status_-s, failing because of the potentially active
pool being detected on the replaced vdev.

/dev/loop0 is part of potentially active pool 'testpool'

Use the default_mirror_setup_noexit() and default_cleanup_noexit()
functions to create the pool in zpool_status_-s. They use the -f
flag by default.

In the scrub_after_resilver test clear wipe the label during cleanup
to prevent a failure in case the tests are reordered again.

How Has This Been Tested?

Manually ran the test cases to verify the failure no longer occurs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
ZTS: Fix zpool_status_-s
40bdab1 
After commit 5e74ac5 which split and reordered the run files the
zpool_status_-s test began failing.  The new ordering placed
the test after a previous test which used `zpool replace` to replace
a disk but did not clear its label.  This resulted the next test,
zpool_status_-s, failing because of the potentially active
pool being detected on the replaced vdev.

    /dev/loop0 is part of potentially active pool 'testpool'

Use the default_mirror_setup_noexit() and default_cleanup_noexit()
functions to create the pool in zpool_status_-s.  They use the -f
flag by default.

In the scrub_after_resilver test clear wipe the label during cleanup
to prevent a failure in case the tests are reordered again.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #9451 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9451      +/-   ##
==========================================
- Coverage   79.08%   79.07%   -0.02%     
==========================================
  Files         412      412              
  Lines      123622   123602      -20     
==========================================
- Hits        97772    97741      -31     
- Misses      25850    25861      +11
Flag Coverage Δ
#kernel 79.7% <ø> (-0.03%) ⬇️
#user 66.68% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715c996...40bdab1. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 11, 2019
@behlendorf behlendorf merged commit ea25ed2 into openzfs:master Oct 11, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
@behlendorf @tonyhutter
ZTS: Fix zpool_status_-s
82dd2b3 
After commit 5e74ac5 which split and reordered the run files the
`zpool_status_-s` test began failing.  The new ordering placed
the test after a previous test which used `zpool replace` to replace
a disk but did not clear its label.  This resulted in the next test,
`zpool_status_-s`, failing because of the potentially active
pool being detected on the replaced vdev.

    /dev/loop0 is part of potentially active pool 'testpool'

Use the default_mirror_setup_noexit() and default_cleanup_noexit()
functions to create the pool in `zpool_status_-s`.  They use the -f
flag by default.

In the `scrub_after_resilver` test wipe the label during cleanup
to prevent future failures if the tests are again reordered.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9451
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@behlendorf @tonyhutter
ZTS: Fix zpool_status_-s
5d5faa3 
After commit 5e74ac5 which split and reordered the run files the
`zpool_status_-s` test began failing.  The new ordering placed
the test after a previous test which used `zpool replace` to replace
a disk but did not clear its label.  This resulted in the next test,
`zpool_status_-s`, failing because of the potentially active
pool being detected on the replaced vdev.

    /dev/loop0 is part of potentially active pool 'testpool'

Use the default_mirror_setup_noexit() and default_cleanup_noexit()
functions to create the pool in `zpool_status_-s`.  They use the -f
flag by default.

In the `scrub_after_resilver` test wipe the label during cleanup
to prevent future failures if the tests are again reordered.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9451
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@behlendorf @tonyhutter
ZTS: Fix zpool_status_-s
c54ee4c 
After commit 5e74ac5 which split and reordered the run files the
`zpool_status_-s` test began failing.  The new ordering placed
the test after a previous test which used `zpool replace` to replace
a disk but did not clear its label.  This resulted in the next test,
`zpool_status_-s`, failing because of the potentially active
pool being detected on the replaced vdev.

    /dev/loop0 is part of potentially active pool 'testpool'

Use the default_mirror_setup_noexit() and default_cleanup_noexit()
functions to create the pool in `zpool_status_-s`.  They use the -f
flag by default.

In the `scrub_after_resilver` test wipe the label during cleanup
to prevent future failures if the tests are again reordered.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9451
@behlendorf behlendorf deleted the zts-zpool_status_-s branch April 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwk404 jwk404 jwk404 approved these changes

@ikozhukhov ikozhukhov ikozhukhov approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@behlendorf @jwk404 @ikozhukhov