Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope struct rangelock #9534

Merged
merged 1 commit into from Nov 1, 2019
Merged

Scope struct rangelock #9534

merged 1 commit into from Nov 1, 2019

Conversation

mattmacy
Copy link
Contributor

A struct rangelock already exists on FreeBSD

Signed-off-by: Matt Macy mmacy@FreeBSD.org

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 30, 2019
@behlendorf behlendorf added this to Code Refactoring in OpenZFS 2.0 Oct 30, 2019
behlendorf
behlendorf reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the types. Two minor changes requested.

module/zfs/zfs_rlock.c Outdated Show resolved Hide resolved
module/zfs/zfs_rlock.c Outdated Show resolved Hide resolved
ahrens
ahrens reviewed Oct 31, 2019
View reviewed changes
module/zfs/zfs_rlock.c Outdated Show resolved Hide resolved
@mattmacy
Scope struct rangelock
c6c02e2 
A struct rangelock already exists on FreeBSD

Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
@codecov
Copy link

codecov bot commented Nov 1, 2019 •
edited

Codecov Report

Merging #9534 into master will decrease coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9534      +/-   ##
==========================================
- Coverage   79.12%   79.06%   -0.06%     
==========================================
  Files         417      417              
  Lines      123678   123678              
==========================================
- Hits        97857    97789      -68     
- Misses      25821    25889      +68
Flag Coverage Δ
#kernel 79.72% <100%> (-0.04%) ⬇️
#user 66.59% <6.06%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab44be1...c6c02e2. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 1, 2019
@behlendorf behlendorf merged commit bd4dde8 into openzfs:master Nov 1, 2019
OpenZFS 2.0 automation moved this from Code Refactoring to Done Nov 1, 2019
@mattmacy mattmacy deleted the projects/zfs_rlock branch December 19, 2019 22:44
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 15, 2020
@mattmacy @tonyhutter
Prefix struct rangelock
317ac8f 
A struct rangelock already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.
This change is a follow up to 2cc479d.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9534
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 22, 2020
@mattmacy @tonyhutter
Prefix struct rangelock
ae6653b 
A struct rangelock already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.
This change is a follow up to 2cc479d.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9534
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 22, 2020
@mattmacy @tonyhutter
Prefix struct rangelock
14cdf17 
A struct rangelock already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.
This change is a follow up to 2cc479d.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9534
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 23, 2020
@mattmacy @tonyhutter
Prefix struct rangelock
85e11c9 
A struct rangelock already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.
This change is a follow up to 2cc479d.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9534
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 28, 2020
@mattmacy @tonyhutter
Prefix struct rangelock
4a336b0 
A struct rangelock already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.
This change is a follow up to 2cc479d.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9534
tonyhutter pushed a commit that referenced this pull request May 12, 2020
@mattmacy @tonyhutter
Prefix struct rangelock
ea15efd 
A struct rangelock already exists on FreeBSD.  Add a zfs_ prefix as
per our convention to prevent any conflict with existing symbols.
This change is a follow up to 2cc479d.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes #9534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens left review comments

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
No open projects
OpenZFS 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattmacy @behlendorf @ahrens