Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change zed.service to zfs-zed.service in man page (fixed) #9581

Merged
merged 1 commit into from Nov 13, 2019

Conversation

Ornias1993
Copy link
Contributor

@Ornias1993 Ornias1993 commented Nov 13, 2019

Fixed style issues from #9563 by @gjedeer (that can be closed now).
Should comply to code-standards now.

zed.service does not exist
replaced with correct service name in man.

Signed-off-by: Kjeld Schouten-Lebbing kjeld@schouten-lebbing.nl

Motivation and Context

The manual advices to use "zed.service" this ends in an error according to #9563

# systemctl enable zed.service
Failed to enable unit: Refusing to operate on linked unit file zed.service
  • New PR because previous author didn't want to follow the contribution guidelines.
  • No legal issues as it's just changing 2 words in the in-application documentation + permission by original author, so no protected work has been violated by copying the changes in a new PR.

Description

This PR corrects the manual to list the correct service name

How Has This Been Tested?

It's changing a word in a manual. 'nuf said.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

zed.service does not exist
replaced with correct service name in man.

Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@Ornias1993
Copy link
Contributor Author

@behlendorf This one solves your issues with #9563 , you might want to also add your approval tag here ;)
Failed test on this one seems onrelated.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Nov 13, 2019
@behlendorf
Copy link
Contributor

Thanks for picking up this cleanup!

@behlendorf behlendorf merged commit 64c77c4 into openzfs:master Nov 13, 2019
@Ornias1993 Ornias1993 deleted the zfsservice-manfix branch December 19, 2019 18:59
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
zed.service does not exist
replaced with correct service name in man.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Closes openzfs#9581
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
zed.service does not exist
replaced with correct service name in man.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Closes openzfs#9581
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
zed.service does not exist
replaced with correct service name in man.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Closes #9581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants