Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zimwriterfs fails when processing a soft-link for CSS file #16

Closed
julianharty opened this issue May 8, 2017 · 3 comments
Closed

zimwriterfs fails when processing a soft-link for CSS file #16

julianharty opened this issue May 8, 2017 · 3 comments
Labels
bug

Comments

@julianharty
Copy link

@julianharty julianharty commented May 8, 2017

Here's what I know, the bug may be more general or very specific to my case. More testing could help identify the extent, for instance to see if the same behavior happens when using soft-links for images, html, etc.

Ingredients:

  • zimwriterfs (I used the current Docker Image that contains it). Note I added a shared folder so I could easily share data between the running Docker image and my macbook. This had to be configured using the command line. See https://github.com/rocker-org/rocker/wiki/Sharing-files-with-host-machine for tips on how to do this.
  • some basic content. I generated it from the https://github.com/julianharty/testing-heuristics project (follow the instructions in the README)
  • create a folder called ./A in the dist folder
  • create a soft-link using ln -s for style.css: ln -s style.css A/style.css
  • run zimwriterfs with the following command (in the extract below) in the running Docker container.

Using a soft-link (ln -s source-file destination-file) caused zimwriterfs to report and error and fail as follows:

root@3090e980e81e:/# zimwriterfs  --uniqueNamespace  -w index.html -f icon.png -l EN -t "Testing Heuristics" -d "Early cut of the testing heuristics material." -c "Julian Harty" -p "Commercetest Ltd." /Volumes/shared/dist/ /Volumes/shared/th-ln.zim

create directory entries
collect articles
zimwriterfs: unable to open file at path: /Volumes/shared/dist/A/style.css
terminate called after throwing an instance of 'int'
Aborted

Copying the file and then re-running the identical zimwriterfs command worked (I had to delete the soft-link first).

rm A/style.css 
cp style.css A/
@julianharty
Copy link
Author

@julianharty julianharty commented May 8, 2017

@kelson42
Copy link
Contributor

@kelson42 kelson42 commented May 12, 2017

This is a bug in zimwriterfs, not in the zimlib.

@kelson42
Copy link
Contributor

@kelson42 kelson42 commented May 12, 2017

This issue was moved to openzim/zimwriterfs#9

@kelson42 kelson42 closed this May 12, 2017
kelson42 pushed a commit that referenced this issue Mar 30, 2020
New writer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.