From 2ac21590e48ae5404f354f36e75be8b22adb8cb1 Mon Sep 17 00:00:00 2001 From: Kelson Date: Thu, 8 May 2025 09:53:47 +0200 Subject: [PATCH 1/6] Add Node.js 24 to the CI --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a4e5b7a..a1b8ccf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-22.04, ubuntu-24.04, macos-13, macos-14, macos-15] - node: [18, 20, 22] + node: [18, 20, 22, 24] runs-on: ${{ matrix.os }} steps: From 079be7df280096f1a9cb60d1afbe3de93e7f0b98 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Sun, 11 May 2025 07:26:23 +0200 Subject: [PATCH 2/6] Remove deprecated Node.js 18 from CI --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a1b8ccf..6d9c5f0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-22.04, ubuntu-24.04, macos-13, macos-14, macos-15] - node: [18, 20, 22, 24] + node: [20, 22, 24] runs-on: ${{ matrix.os }} steps: From c498ff9025ff28b3df29ce73ca08edee2130e00e Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Sun, 11 May 2025 07:27:32 +0200 Subject: [PATCH 3/6] Use Node.js 20 in CD --- .github/workflows/cd.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 42864a5..ee7c5c7 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -12,10 +12,10 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - - name: Use Node.js 18.x + - name: Use Node.js 20.x uses: actions/setup-node@v4 with: - node-version: "18.x" + node-version: "20.x" registry-url: "https://registry.npmjs.org" - run: npm ci From fff500ac1ec8e1b5d672d861d226cd7e5c47788d Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Sun, 11 May 2025 07:31:08 +0200 Subject: [PATCH 4/6] Add explicit supported runtimes dep --- package-lock.json | 3 +++ package.json | 3 +++ 2 files changed, 6 insertions(+) diff --git a/package-lock.json b/package-lock.json index 68c22f4..5ee5ca4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -35,6 +35,9 @@ "prettier": "^3.3.2", "ts-jest": "^29.1.5", "typescript": "^5.1.6" + }, + "engines": { + "node": ">=20 <=24" } }, "node_modules/@ampproject/remapping": { diff --git a/package.json b/package.json index 00d04c7..dfb2d4a 100644 --- a/package.json +++ b/package.json @@ -38,6 +38,9 @@ "bugs": { "url": "https://github.com/openzim/node-libzim/issues" }, + "engines": { + "node": ">=20 <=24" + }, "homepage": "https://github.com/openzim/node-libzim#readme", "gypfile": true, "dependencies": { From f9704edadcecf911ea682c5f12b8ae82e60ef135 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Fri, 16 May 2025 15:45:58 +0200 Subject: [PATCH 5/6] Add .npmrc (to enforce runtime engine) --- .npmrc | 1 + 1 file changed, 1 insertion(+) create mode 100644 .npmrc diff --git a/.npmrc b/.npmrc new file mode 100644 index 0000000..4fd0219 --- /dev/null +++ b/.npmrc @@ -0,0 +1 @@ +engine-strict=true \ No newline at end of file From 332fc7b9329b0e8f84e558533ef9ee4d9f7e26a0 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Sat, 17 May 2025 13:40:28 +0200 Subject: [PATCH 6/6] Clearer version scoping for Node.js --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 5ee5ca4..44c3463 100644 --- a/package-lock.json +++ b/package-lock.json @@ -37,7 +37,7 @@ "typescript": "^5.1.6" }, "engines": { - "node": ">=20 <=24" + "node": ">=20 <25" } }, "node_modules/@ampproject/remapping": { diff --git a/package.json b/package.json index dfb2d4a..0a6bd50 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "url": "https://github.com/openzim/node-libzim/issues" }, "engines": { - "node": ">=20 <=24" + "node": ">=20 <25" }, "homepage": "https://github.com/openzim/node-libzim#readme", "gypfile": true,