Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds http.method tag by default and removes bad naming advice (#616)
This adds the http.method tag by default as many frameworks override the span name, or will as soon as http.route is supported. This allows users to always see basic http info at the cost of a small, fixed cardinality tag. Users who really don't want to see this tag can already disable parsing of it by overriding the default parser. This also removes the bad advice from the README, which hinted at using a path as a span name. This will result in ever-expanding span name index when there are path variables. The http route based approach is superior and merges next.
- Loading branch information
1 parent
5bea163
commit 7696082
Showing
3 changed files
with
30 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters