Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1045: Fix tracing of JAX-RS2 compatible clients. #1046

Merged
merged 2 commits into from Jan 24, 2020

Conversation

@SimY4
Copy link
Contributor

SimY4 commented Dec 1, 2019

Addresses the issue when JAX-RS filter is unable to set the tracing headers because it's using the immutable view on request header's map.

Some tests are flaky, not sure how to fix them yet.
@SimY4 SimY4 force-pushed the SimY4:master branch 2 times, most recently from c2f7852 to ef81d41 Dec 2, 2019
@SimY4 SimY4 force-pushed the SimY4:master branch from ef81d41 to 6cbf5e0 Dec 2, 2019
@SimY4 SimY4 changed the title fix #1045: Add tests for JAX-RS2 async client. fix #1045: Fix tracing of JAX-RS2 compatible clients. Dec 20, 2019
@adriancole

This comment has been minimized.

Copy link
Contributor

adriancole commented Jan 24, 2020

this sounds like a bug in the JAX-RS impl based on the javadoc:

     * Changes in the underlying {@link #getHeaders() headers map} are reflected
     * in this view.
@adriancole

This comment has been minimized.

Copy link
Contributor

adriancole commented Jan 24, 2020

anyway works for me! thanks

@adriancole adriancole merged commit fab0c32 into openzipkin:master Jan 24, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.