Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Streams: Propagate context between stream operations #957

Merged
merged 3 commits into from Aug 7, 2019

Conversation

@jeqo
Copy link
Member

jeqo commented Aug 6, 2019

Fix #956

Current implementation is treating each stream operation as a child of the span created at initial consumption.

This leads to issues like #956, as there is no propagation between stream operations.

This PR fix this by injecting context before leaving each operation.

jeqo added 3 commits Aug 6, 2019
@jeqo jeqo marked this pull request as ready for review Aug 7, 2019
timtebeek added a commit to timtebeek/kafka-streams-log-correlation that referenced this pull request Aug 7, 2019
@jeqo jeqo merged commit e22673d into master Aug 7, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jeqo jeqo deleted the kafka-check-propagation branch Aug 7, 2019
@adriancole

This comment has been minimized.

Copy link
Contributor

adriancole commented Aug 7, 2019

@adriancole

This comment has been minimized.

Copy link
Contributor

adriancole commented Aug 11, 2019

5.6.10 has this and also I updated all versions of sleuth to have it. so whatever the next version will definitely have it :P

@timtebeek

This comment has been minimized.

Copy link

timtebeek commented Aug 11, 2019

Awesome! Thanks a lot! :)

timtebeek added a commit to timtebeek/kafka-streams-log-correlation that referenced this pull request Oct 6, 2019
Verify openzipkin/brave#957 through ExtraFieldPropagation.set/get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.