Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept more spark configuration #151

Merged
merged 2 commits into from Oct 16, 2019

Conversation

@addozhang
Copy link
Contributor

commented Sep 25, 2019

refer to #150

Addo.Zhang
Copy link
Contributor

left a comment

This seems ok with me. @jorgheymans I think you use this. wdyt?

@@ -145,6 +151,7 @@ private static String getEnv(String key, String defaultValue) {
if (builder.jars != null) conf.setJars(builder.jars);
for (Map.Entry<String, String> entry : builder.sparkProperties.entrySet()) {
conf.set(entry.getKey(), entry.getValue());
log.info("Spark conf properties: {}={}", entry.getKey(), entry.getValue());

This comment has been minimized.

Copy link
@adriancole

adriancole Sep 25, 2019

Contributor

please change all these to debug level just in case there's a sensitive property.

@@ -19,7 +19,9 @@
import java.net.URLDecoder;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.HashMap;

This comment has been minimized.

Copy link
@adriancole

adriancole Sep 25, 2019

Contributor

please use linkedhashmap for consistent ordering

@addozhang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

@adriancole Thanks for your advice. Changes done.

@jorgheymans

This comment has been minimized.

Copy link

commented Sep 25, 2019

useful, LGTM

@adriancole adriancole merged commit f3c9ff1 into openzipkin:master Oct 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.