Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest tagged version requires a bad grpc module version #114

Closed
dmitshur opened this Issue Feb 28, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@dmitshur
Copy link
Contributor

dmitshur commented Feb 28, 2019

The current latest version of the github.com/openzipkin/zipkin-go module is v0.1.5. Its go.mod file requires the module google.golang.org/grpc at version v1.16.0:

https://github.com/openzipkin/zipkin-go/blob/v0.1.5/go.mod#L27

That version is old, and has an issue where it requires the module golang.org/x/lint twice:

https://github.com/grpc/grpc-go/blob/v1.16.0/go.mod#L7
https://github.com/grpc/grpc-go/blob/v1.16.0/go.mod#L11

The first time it's being required via the module path github.com/golang/lint, which is not compatible with the module path specified in the latest master commit of that repository:

https://github.com/golang/lint/blob/5b3e6a55c961c61f4836ae6868c17b070744c590/go.mod#L1

As a result, when in module mode, doing go get -u github.com/openzipkin/zipkin-go fails:

$ cd $(mktemp -d)
$ export GO111MODULE=on
$ go get -u github.com/openzipkin/zipkin-go
go: finding github.com/golang/snappy v0.0.1
go: finding github.com/Shopify/sarama v1.21.0
go: github.com/golang/lint@v0.0.0-20190227174305-5b3e6a55c961: parsing go.mod: unexpected module path "golang.org/x/lint"
go get: error loading module requirements

Because this affects the latest version of this module, which is being required by other modules, it indirectly causes the issue golang/lint#436.

To fix this problem, you need to update go.mod to require a newer version of the grpc module and issue a new version. I can send a PR for the go.mod file change.

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Feb 28, 2019

I can send a PR for the go.mod file change.

I've sent PR #115 that'll fix this issue (after it's merged and a new tag is created). /cc @basvanbeek @jcchavezs

@dmitshur dmitshur changed the title Latest tagged version requires an bad grpc module version. Latest tagged version requires an bad grpc module version Feb 28, 2019

@dmitshur dmitshur changed the title Latest tagged version requires an bad grpc module version Latest tagged version requires a bad grpc module version Feb 28, 2019

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Mar 13, 2019

I've reopened this as #117 because a new tag still needs to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.