Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Latest tagged version still requires a bad grpc module version #117
This is a continuation of issue #114.
It has been resolved via PR #115, which has been merged. However, a new tag hasn't been created yet, which means v0.1.5 is still the latest version of zipkin-go, and now that
It can be reproduced with Go 1.12 as follows:
Please consider making a new tag that includes the fix from PR #115 in order to fix the latest version of zipkin-go. Thanks!
This was referenced
Mar 13, 2019
I will create such tag today. Den tor. 14. mar. 2019, 07:45 skrev Chris Broadfoot < email@example.com>:…
/cc @broady <https://github.com/broady> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7sAkAVKRQlyBAB0XQyHyn_Su1AkjUyks5vWe_4gaJpZM4btxIS> .
Thank you for doing that!
Unfortunately, while making the new tag helped, it wasn't sufficient to resolve the issue. The bad grpc v1.16.0 still ends up being in the build list (but now for different reasons):
I'm finding the following reasons for grpc v1.16.0 showing up:
There's been progress made. Right now, I think one of the next blocking pieces to resolve is googleapis/google-api-go-client#342 and census-instrumentation/opencensus-go#1064 (comment).
Once those are resolved, the latest version of