Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update grpc from v1.16.0 to v1.17.0 #115

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
5 participants
@dmitshur
Copy link
Contributor

dmitshur commented Feb 28, 2019

Update the grpc dependency to v1.17.0, which includes the fix
to remove the invalid github.com/golang/lint module requirement
in grpc/grpc-go#2393.

Additionally, the currently specified pseudo-version of the genproto module,
which is v0.0.0-20181109154231-b5d43981345b, itself requires grpc v1.16.0.

Drop this indirect requirement, since it's not needed for the purposes
of the main zipkin-go module.

This change was generated by running the following commands
using Go 1.2:

go get google.golang.org/grpc@v1.17.0
go mod edit -droprequire=google.golang.org/genproto
go mod tidy

Fixes #114
Updates golang/lint#436

go.mod: update grpc from v1.16.0 to v1.17.0
Update the grpc dependency to v1.17.0, which includes the fix
to remove the invalid github.com/golang/lint module requirement
in grpc/grpc-go#2393.

This change was generated by running the following commands
using Go 1.2:

	go get google.golang.org/grpc@v1.17.0
	go mod tidy

Fixes #114
Updates golang/lint#436
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 28, 2019

Coverage Status

Coverage remained the same at 66.25% when pulling fd2c0fa on dmitshur:update-grpc into 62dc8b2 on openzipkin:master.

@dmitshur dmitshur referenced this pull request Feb 28, 2019

Closed

Unexpected module path #436

Show resolved Hide resolved go.mod Outdated
go.mod: drop indirect requirement of genproto
The currently specified pseudo-version of the genproto module, which
is v0.0.0-20181109154231-b5d43981345b, itself requires grpc v1.16.0.

Drop this indirect requirement, since it's not needed for the purposes
of the main zipkin-go module.

This change was generated by running the following commands
using Go 1.2:

	go mod edit -droprequire=google.golang.org/genproto
	go mod tidy
@jcchavezs

This comment has been minimized.

Copy link
Contributor

jcchavezs commented Feb 28, 2019

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Feb 28, 2019

Are you asking if it’s possible to detect an issue like #114 in CI? I’m not sure right now, but I’ll think more about it.

An initial idea is to have a script that creates an empty module and does go get -u github.com/openzipkin/zipkin-go in it. But I recommend thinking more about the implications of doing this (in a separate issue) before committing to it.

@jcchavezs

This comment has been minimized.

Copy link
Contributor

jcchavezs commented Mar 1, 2019

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Mar 1, 2019

Sounds good.

Is there anything you need from me to make progress on this PR?

To clarify, this is ready from my side.

@jcchavezs

This comment has been minimized.

Copy link
Contributor

jcchavezs commented Mar 3, 2019

@basvanbeek do you have any input on this? Otherwise I will just merge it.

@basvanbeek basvanbeek merged commit 1b5162a into openzipkin:master Mar 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 66.25%
Details
@basvanbeek

This comment has been minimized.

Copy link
Collaborator

basvanbeek commented Mar 4, 2019

Thanks @dmitshur for the PR and thanks @jcchavezs for helping out here.

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Mar 4, 2019

No problem!

Just checking, are you planning on making a new release? Issue #114 is not yet fully resolved until this change is included in the latest released tag. The current latest v0.1.5 doesn't include this change yet.

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Mar 13, 2019

I've filed issue #117 about making a new tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.