Permalink
Browse files

ui: replace static link with url update

Rather than displaying a `link` button to the static search page, update
the URL so it contains the same info.

Author: @franklinhu
Fixes #182
URL: #182
  • Loading branch information...
1 parent 954c8ac commit 0db03911c6615dfc950560bc1c24fc00472aa1ca @franklinhu franklinhu committed with Franklin Hu Oct 18, 2012
@@ -445,9 +445,9 @@ Zipkin.Application.Index = (function() {
var queryResults = query.execute();
queryResultsView = new QueryResultsView({collection: queryResults});
- /* Shove the query string into the static link */
+ /* Update the URL to reflect the search */
searchQuery = queryResults.url().split("?")[1];
- $("#static-search-link").attr("href", root_url + "?" + searchQuery).show();
+ history.pushState({}, "Zipkin", root_url + "?" + searchQuery);
return false;
};
@@ -546,10 +546,6 @@ Zipkin.Application.Index = (function() {
return false;
});
- $(document).on("click", "li.trace", function(e) {
- history.pushState({}, "Zipkin", root_url + "?" + searchQuery);
- });
-
Zipkin.Base.initialize();
var params = Zipkin.Util.queryParams();
@@ -47,7 +47,6 @@
<div class="sidebar-block filter-block-contents filter-submit">
<button class="btn primary" disabled>Find traces</button>
<a data-toggle="modal" href="#lookup-help-modal" class="btn"><i class="icon-info-sign"></i></a>
- <a id="static-search-link" class="hide pull-right">link</a>
</div>
</form>

0 comments on commit 0db0391

Please sign in to comment.