Skip to content

Commit

Permalink
Don't sort span names in elasticsearch (#1463)
Browse files Browse the repository at this point in the history
While probably not a big contributor to performance, we don't need to
sort span names in elasticsearch as we already copy out into a sorted
list.

See #1462
  • Loading branch information
adriancole committed Jan 2, 2017
1 parent 95d17b0 commit 56fbfab
Showing 1 changed file with 1 addition and 4 deletions.
Expand Up @@ -214,10 +214,7 @@ ListenableFuture<List<List<Span>>> getTracesByIds(Collection<String> traceIds, S

return client.collectBucketKeys(catchAll,
boolQuery().must(matchAllQuery()).filter(filter),
AggregationBuilders.terms("name_agg")
.order(Order.term(true))
.field("name")
.size(Integer.MAX_VALUE));
AggregationBuilders.terms("name_agg").field("name").size(Integer.MAX_VALUE));
}

@Override public ListenableFuture<List<DependencyLink>> getDependencies(long endMillis,
Expand Down

0 comments on commit 56fbfab

Please sign in to comment.