From 56fbfab9514a799360f5142e5b0aa7ccf1a34ec9 Mon Sep 17 00:00:00 2001 From: Adrian Cole Date: Mon, 2 Jan 2017 19:56:34 +0800 Subject: [PATCH] Don't sort span names in elasticsearch (#1463) While probably not a big contributor to performance, we don't need to sort span names in elasticsearch as we already copy out into a sorted list. See #1462 --- .../zipkin/storage/elasticsearch/ElasticsearchSpanStore.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/zipkin-storage/elasticsearch/src/main/java/zipkin/storage/elasticsearch/ElasticsearchSpanStore.java b/zipkin-storage/elasticsearch/src/main/java/zipkin/storage/elasticsearch/ElasticsearchSpanStore.java index def9ec56ba..a9fdea0f91 100755 --- a/zipkin-storage/elasticsearch/src/main/java/zipkin/storage/elasticsearch/ElasticsearchSpanStore.java +++ b/zipkin-storage/elasticsearch/src/main/java/zipkin/storage/elasticsearch/ElasticsearchSpanStore.java @@ -214,10 +214,7 @@ ListenableFuture>> getTracesByIds(Collection traceIds, S return client.collectBucketKeys(catchAll, boolQuery().must(matchAllQuery()).filter(filter), - AggregationBuilders.terms("name_agg") - .order(Order.term(true)) - .field("name") - .size(Integer.MAX_VALUE)); + AggregationBuilders.terms("name_agg").field("name").size(Integer.MAX_VALUE)); } @Override public ListenableFuture> getDependencies(long endMillis,