Permalink
Commits on Jan 17, 2017
  1. Polishes release configuration (#1493)

    adriancole committed on GitHub Jan 17, 2017
Commits on Jan 16, 2017
  1. Bumps test images

    adriancole committed Jan 16, 2017
  2. [maven-release-plugin] prepare for next development iteration

    zipkinci committed Jan 16, 2017
  3. [maven-release-plugin] prepare release 1.19.2

    zipkinci committed Jan 16, 2017
  4. Bumps dependency versions

    adriancole committed Jan 16, 2017
  5. Skips creating dependency links when the serviceName is empty string (#…

    …1491)
    
    Sometimes, empty string is sent for endpoint.serviceName. This prevents
    empty string from showing up in the dependency graph.
    adriancole committed on GitHub Jan 16, 2017
  6. do not silently drop subsequent spans missing a parent (#1487)

    Currently zipkin models traces as a tree of spans.  During the
    conversation from a list (or whatever the underlying storage engine
    uses) to a tree, spans are dropped if more than one of them is missing
    a parentId (it is a "root" node).  This appears to be an unintentional
    regression (possibly around 9d8261a),
    since the comment still indicate a workaround for this problem:
    attribute missing parents to root.
    
    This is still imperfect, but exposes it to the the user so they can
    debug the instrumentation problem instead of silently dropping data.
    Note that the workaround only applies when constructing a tree
    internally the actual spans returned by the API still have no
    parentID, and this is what is displayed in the web ui.
    
    This problem is alluded to in #324, but the thrust of that ticket is
    modeling asynchronous actions.
    
    Highlighting suspect traces is discussed in #1484 and this condition
    would be a prime candidate.
    cburroughs committed with adriancole Jan 16, 2017
  7. Consolidates logic that deals with embedded IPv4 addresses (#1490)

    This consolidates logic around mapped or embedded IPv4 addresses, as
    previously logic was duplicated here and in Brave.
    adriancole committed on GitHub Jan 16, 2017
  8. Fixes bad self-tracing configuration resulting in unknown serviceName (

    adriancole committed on GitHub Jan 16, 2017
  9. Fixes issue typo on MySQL performance

    thanks to @shakuzen for noticing
    adriancole committed on GitHub Jan 16, 2017
Commits on Jan 12, 2017
  1. explicitly exclude ui from license instructions

    adriancole committed Jan 12, 2017
Commits on Jan 11, 2017
  1. Kicks out instead of correcting skew on single-host spans (#1483)

    An instrumentation glitch can look like clock skew. This kicks out when
    RPC annotations all belong to the same host.
    
    This also backfills tests.
    adriancole committed on GitHub Jan 11, 2017
Commits on Jan 9, 2017
  1. [maven-release-plugin] prepare for next development iteration

    zipkinci committed Jan 9, 2017
  2. [maven-release-plugin] prepare release 1.19.1

    zipkinci committed Jan 9, 2017
  3. Moves off deprecated brave methods (#1467)

    This updates to the latest version of Brave and avoids deprecated code.
    adriancole committed on GitHub Jan 9, 2017
  4. Switches to release commit user instead of amplifying my commits (#1476)

    This switches to a dummy user instead of my email when doing release
    commits.
    adriancole committed on GitHub Jan 9, 2017
  5. Backfills tests for async spans in the dependencies graph (#1478)

    This unveiled a small bug left unnoticed.
    adriancole committed on GitHub Jan 9, 2017
  6. Update developers section in pom.xml (#1477)

    Developers section content is outdated. It is required
    for publishing to Maven Central so update with Zipkin dev
    google group info.
    adriancole committed on GitHub Jan 9, 2017
  7. Formatting and polish

    adriancole committed Jan 9, 2017
  8. Clarifies why we format data in spanPanel.js (#1474)

    I found it confusing that we format data both in traceToMustache and
    spanPanel. This hopefully explains a bit better, and also cleans up
    some javascript along the way.
    adriancole committed on GitHub Jan 9, 2017
Commits on Jan 8, 2017
  1. Flags yellow for annotations that match case insensitive error (#1475)

    Particularly, this flags existing finagle formatted errors, like so:
    "Server Send Error: TimeoutException: socket timed out"
    
    Fixes #1472
    See openzipkin/openzipkin.github.io#52
    adriancole committed on GitHub Jan 8, 2017
Commits on Jan 6, 2017
  1. Backfills UI tests for annotation and binary annotation value formatt…

    …ing (#1473)
    
    See #1458
    adriancole committed on GitHub Jan 6, 2017
Commits on Jan 5, 2017
  1. Clock skew correction is not propagated to more than one level of loc…

    …al span. (#1470)
    
    Since local spans share the same clock skew as the server they are running on, we need to propagate to children.
    fedj committed with adriancole Jan 5, 2017
Commits on Jan 4, 2017
  1. Created index for zipkin_annotations, so DEPENDENCIES can run faster (#…

    …1471)
    
    Having 238460 rows inside zipkin_annotations, show this benefit :
    
    BEFORE
    ---
    mysql> explain  SELECT `trace_id_high`,`trace_id`,`parent_id`,`id`,`a_key`,`endpoint_service_name` FROM (select distinct s.trace_id_high, s.trace_id, s.parent_id, s.id, a.a_key, a.endpoint_service_name from zipkin_spans s left outer join zipkin_annotations a on   (s.trace_id = a.trace_id and s.id = a.span_id and a.a_key in ('ca', 'cs', 'sr', 'sa')) where s.start_ts between 1483401600000000 and 1483487999999999 group by s.trace_id_high, s.trace_id, s.id, a.a_key, a.endpoint_service_name)  as link_spans;
    +------+-------------+------------+------+---------------+------+---------+------+------------+-------------------------------------------------+
    | id   | select_type | table      | type | possible_keys | key  | key_len | ref  | rows       | Extra                                           |
    +------+-------------+------------+------+---------------+------+---------+------+------------+-------------------------------------------------+
    |    1 | PRIMARY     | <derived2> | ALL  | NULL          | NULL | NULL    | NULL | 2529761520 |                                                 |
    |    2 | DERIVED     | s          | ALL  | start_ts      | NULL | NULL    | NULL |      94380 | Using where; Using temporary                    |
    |    2 | DERIVED     | a          | ALL  | a_key         | NULL | NULL    | NULL |     236871 | Using where; Using join buffer (flat, BNL join) |
    
    AFTER
    ---
    mysql> explain  SELECT `trace_id_high`,`trace_id`,`parent_id`,`id`,`a_key`,`endpoint_service_name` FROM (select distinct s.trace_id_high, s.trace_id, s.parent_id, s.id, a.a_key, a.endpoint_service_name from zipkin_spans s left outer join zipkin_annotations a on   (s.trace_id = a.trace_id and s.id = a.span_id and a.a_key in ('ca', 'cs', 'sr', 'sa')) where s.start_ts between 1483401600000000 and 1483487999999999 group by s.trace_id_high, s.trace_id, s.id, a.a_key, a.endpoint_service_name)  as link_spans;
    +------+-------------+------------+------+---------------+------+---------+-------------------------------+-------+------------------------------+
    | id   | select_type | table      | type | possible_keys | key  | key_len | ref                           | rows  | Extra                        |
    +------+-------------+------------+------+---------------+------+---------+-------------------------------+-------+------------------------------+
    |    1 | PRIMARY     | <derived2> | ALL  | NULL          | NULL | NULL    | NULL                          | 47190 |                              |
    |    2 | DERIVED     | s          | ALL  | start_ts      | NULL | NULL    | NULL                          | 94380 | Using where; Using temporary |
    |    2 | DERIVED     | a          | ref  | a_key,akey    | akey | 16      | zipkin.s.trace_id,zipkin.s.id |     1 | Using where                  |
    +------+-------------+------------+------+---------------+------+---------+-------------------------------+-------+------------------------------+
    josetesan committed with adriancole Jan 4, 2017
  2. Span timestamp is not correctly correct in case of clock skew. (#1468)

    In case of clock skew, the timestamp of the span is not modified correctly. Its value is set to the value of the first annotation which can be wrong.
    fedj committed with adriancole Jan 4, 2017
  3. Fixes NPE when Span.Builder merge other span w/o initializing traceId…

    …High (#1469)
    kojilin committed with adriancole Jan 4, 2017
  4. show {trace,span}-id in span details pane (#1434)

    Hidden at the bottom since it is primarily intended as a debugging
    convenience.
    
    ref #1300
    cburroughs committed with adriancole Jan 4, 2017
Commits on Jan 3, 2017
  1. updates to latest docker images

    adriancole committed Jan 3, 2017
  2. Adds release instructions for next year (#1466)

    adriancole committed on GitHub Jan 3, 2017
Commits on Jan 2, 2017
  1. [maven-release-plugin] prepare for next development iteration

    adriancole committed Jan 2, 2017
  2. [maven-release-plugin] prepare release 1.19.0

    adriancole committed Jan 2, 2017
  3. Fixes license headers in poms

    adriancole committed Jan 2, 2017
  4. Fixes broken license header

    adriancole committed Jan 2, 2017
  5. Don't sort span names in elasticsearch (#1463)

    While probably not a big contributor to performance, we don't need to
    sort span names in elasticsearch as we already copy out into a sorted
    list.
    
    See #1462
    adriancole committed on GitHub Jan 2, 2017
  6. Clock skew correction is now applied. (#1465)

    When traces begin by SR-SS, clock skew correction wasn't applied.
    fedj committed with adriancole Jan 2, 2017