Zipkin server as a CloudFoundry service #1251

Open
hvandenb opened this Issue Aug 23, 2016 · 19 comments

Projects

None yet

5 participants

@hvandenb

To simplify the deployment of Zipkin within CloudFoundry/Pivotal has there been some thought on making it a CF service. This way projects like Sleuth can just "bind" to Zipkin. This would be a similar approach as what has been done with Eureka and the Discovery Server of Eureka. Interested in hearing thoughts on this.

@adriancole
Contributor
@hvandenb

The bosh release looks interesting. I've been able to deploy it as a normal java app without any issue. Using Sleuth with my apps. However, I like the simplicity of being able to doing a cf bind or adding Zipin as a service dependency in the manifest. That way apps don't have to know about all the HTTPS and/or streaming to Zipkin server.

@eirslett
Contributor

Would it be able to setup a transitive dependency on cassandra as well? Ease of deployment is always a good thing :)

@adriancole
Contributor

bosh used to..
https://github.com/frodenas/zipkin-boshrelease/tree/master/packages

definitely would need some cleanup. Also, no idea if bosh-lite makes this
easier now. https://github.com/cloudfoundry/bosh-lite

On Tue, Aug 23, 2016 at 10:38 PM, Eirik Sletteberg <notifications@github.com

wrote:

Would it be able to setup a transitive dependency on cassandra as well?
Ease of deployment is always a good thing :)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1251 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61w8yBBxSgjaxn8K67kkow9FCNgSKks5qiwXTgaJpZM4JqfUV
.

@adriancole
Contributor

not sure if this helps, but pivotal web services (powered by cloud foundry) has been successfully used in sleuth

https://github.com/spring-cloud/spring-cloud-sleuth/blob/2f93bd955a3399224a3cef5d799064342a28e0e7/docs/src/main/asciidoc/spring-cloud-sleuth.adoc#running-examples

@marcingrzejszczak @dsyer do you have any instructions you can paste links to (or just c&p here?)

@adriancole
Contributor

@shakuzen mentioned we could also look at porting from a similar guide, like this one http://blog.hazelcast.com/cloud-foundry/

@marcingrzejszczak

@hvandenb @adriancole there's some work in progress on the topic. Until now it's possible to do it without having a separate tile for that. Check out the brewery which is also deployed to CF and tested there - https://github.com/spring-cloud-samples/brewery

@hvandenb

Like the Hazelcast guide with two options

  • deploy normal and define user service
  • bosh managed with marketplace

I remember seeing a tool at Springone that simplifies the marketplace / service broker part will have to look back at the conf materials.

@hvandenb

On @eirslett comment I like what Spring Cloud Dataflow has done where they use a DPI (think Java spi) for deployments that makes it agnostic of runtime platform. So you can deploy on cloud foundry, kubernetics, docker etc. in consistent manner.

@adriancole
Contributor

kudos shoutout to @mminella and team on that deployment niceness. maybe we could open a repo for something similar for zipkin, if someone's up to task (pun intended)

@hvandenb

There is also a nice project to do the title - marketplace generation http://cf-platform-eng.github.io/isv-portal/ Time to start pulling something together.

@adriancole
Contributor

@tushar-dadlani if you know of any place users can go to when asking about CF, please note here!

@adriancole
Contributor

For those interested, the next OSS Cloud Foundry release (cf-245) will introduce the first phase of Zipkin support.

Once this is out, it should probably be communicated more broadly via our existing implementations list, zipkin-user and twitter.

You can stalk https://github.com/cloudfoundry/cf-release/releases for details, but here's a sneak preview from @shalako (who's to thank for driving this feature).


Zipkin is an optional feature that operators enable by specifying a configuration property in their BOSH deployment manifest:

router.tracing.enable_zipkin:true

This is support for developer correlation via logs only. When enabled the CF HTTP router (gorouter) will:

  • initiate trace id when trace id and span id are not present in the received request: forward X-B3-TraceId with requests to apps and log x_b3_traceid in access log
  • always initiate a span id: forward X-B3-SpanId with requests to apps and log x_b3_spanid in access log
  • initiate parent span id when trace id and span id are present: forward X-B3-ParentSpan with requests to apps and log x_b3_parentspanid in access log
@hvandenb

@shalako great work for pushing this I really look forward to seeing this.

@adriancole
Contributor

@shalako I noticed that 245 is out, but there's no mention of this feature in the main or router release notes https://github.com/cloudfoundry/cf-release/releases/tag/v245 can you ping us when the release notes are updated? cc @tushar-dadlani

@shalako
shalako commented Oct 14, 2016

Release notes for cf-release v243 noted a bump to routing-release v138
https://github.com/cloudfoundry/cf-release/releases/tag/v243

In release notes for routing-release 138 we note initial support for the
new zipkin config property
https://github.com/cloudfoundry-incubator/routing-release/releases/tag/0.138.0

Release notes for v245 noted a bump to routing-release v140 (so includes
changes in routing-release 139 also)

In release notes for routing-release 139 we note added enhancements to
Zipkin support
https://github.com/cloudfoundry-incubator/routing-release/releases/tag/0.139.0

Shannon Coen
Product Manager, Cloud Foundry
Pivotal, Inc.

On Thu, Oct 13, 2016 at 6:12 PM, Adrian Cole notifications@github.com
wrote:

@shalako https://github.com/shalako I noticed that 245 is out, but
there's no mention of this feature in the main or router release notes
https://github.com/cloudfoundry/cf-release/releases/tag/v245 can you ping
us when the release notes are updated? cc @tushar-dadlani
https://github.com/tushar-dadlani


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1251 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJjmM1gFCXtux2kMaERD6aVHlVfY-y1ks5qztcFgaJpZM4JqfUV
.

@adriancole
Contributor
@adriancole
Contributor
@adriancole
Contributor

looks like zipkin is mentioned in recent pivotal cloud foundry notes: https://twitter.com/making/status/800708459041722368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment