New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span names not updated on first time view #1440

Closed
cburroughs opened this Issue Dec 16, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@cburroughs
Contributor

cburroughs commented Dec 16, 2016

On the first view of of the search page the zipkin UI loads the service names. But does not load the span names for that service.

snap-name-0

However, we save last-serviceName as a cookie so this won't occur after a service name is selected, or if a service name query parameter is present.

snap-name-1

cburroughs added a commit to cburroughs/zipkin that referenced this issue Dec 16, 2016

cleanup first load events for service/span names
During initialization an unconditional `uiChangeServiceName` is fired
to populate the lists of service and corresponding span names.  This
had two problematic consequence:
 * Since there was no service name yet, an http request for spans in
   the `undefined` service was made (looking "bad" in dev tools).
 * On first load we never went back and loaded the span names if no
   service was selected (via query parameters or cookies).  This meant
   the list of span names would just be "all".

These can both be resolved by:
 * Guarding against span search queries when no service name is set.
 * Loading the spans names for the first service in the list when no
   service name is set.

ref openzipkin#1440 openzipkin#1072

adriancole added a commit that referenced this issue Dec 19, 2016

cleanup first load events for service/span names (#1441)
During initialization an unconditional `uiChangeServiceName` is fired
to populate the lists of service and corresponding span names.  This
had two problematic consequence:
 * Since there was no service name yet, an http request for spans in
   the `undefined` service was made (looking "bad" in dev tools).
 * On first load we never went back and loaded the span names if no
   service was selected (via query parameters or cookies).  This meant
   the list of span names would just be "all".

These can both be resolved by:
 * Guarding against span search queries when no service name is set.
 * Loading the spans names for the first service in the list when no
   service name is set.

ref #1440 #1072

@cburroughs cburroughs closed this Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment