Cleanup modules #152

Closed
franklinhu opened this Issue Sep 19, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

franklinhu commented Sep 19, 2012

Currently we have a confusing hierarchy of modules for the collector and query services including:

  • zipkin-common: common classes shared between the two
  • zipkin-thrift: Thrift structs and interfaces for both services
  • zipkin-scrooge: module to generate Scala from Thrift via Scrooge
  • zipkin-scribe: scribe specific classes for collector, including the service
  • zipkin-server: combination of code for collector and query, including the query service

I think we can clean this up by breaking up the latter two modules and make things more composable.

  • zipkin-cassie: implementation of Aggregates, Index, and Storage interfaces that use Cassandra as the backing store
  • zipkin-collector-core: core code for the collector service
  • zipkin-collector-scribe: scribe specific classes
  • zipkin-collector-service: module to compose everything together
  • zipkin-query-core: core code for query service
  • zipkin-query-service: module to compose everything together
Contributor

mosesn commented Sep 19, 2012

Where will the Aggregates, Index, and Storage interfaces live? Core?

Contributor

johanoskarsson commented Sep 19, 2012

Overall a good idea. Some feedback:

  • I'd change zipkin-cassie to zipkin-cassandra so as not to tie it to the client used.
  • We might get away without the -core modules for now, we will get tons of modules with this change.
  • Make sure you clearly write up which module does what in the readme (or maybe even a readme per module)
Contributor

franklinhu commented Sep 19, 2012

@mosesn I've already moved them to zipkin-common so they can be shared across all the modules

franklinhu pushed a commit that referenced this issue Sep 20, 2012

zipkin-cassandra refactor
- Refactor cassandra dependencies out of `zipkin-server` and into a separate
  submodule, `zipkin-cassandra`
- Make `zipkin-server` depend on the `zipkin-cassandra` submodule.

This change is a part of #152.

Author: @franklinhu
Fixes #153
URL: #153

franklinhu pushed a commit that referenced this issue Sep 20, 2012

Collector refactor
Move collector specific code to `zipkin-collector-core`

This is a part of #152

Author: @franklinhu
Fixes #154
URL: #154

franklinhu pushed a commit that referenced this issue Sep 20, 2012

franklinhu pushed a commit that referenced this issue Sep 21, 2012

@franklinhu franklinhu closed this Sep 25, 2012

adriancole added a commit that referenced this issue Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment