Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

ui: replace static link with url update #182

Closed
wants to merge 1 commit into from

2 participants

@franklinhu

Rather than displaying a link button to the static search page, update the URL so it contains the same info.

@franklinhu franklinhu closed this pull request from a commit
@franklinhu franklinhu ui: replace static link with url update
Rather than displaying a `link` button to the static search page, update
the URL so it contains the same info.

Author: @franklinhu
Fixes #182
URL: #182
0db0391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 17, 2012
  1. Replace static search link with URL pushState

    Franklin Hu authored
This page is out of date. Refresh to see the latest.
View
8 zipkin-finatra/src/main/resources/public/js/application-index.js
@@ -445,9 +445,9 @@ Zipkin.Application.Index = (function() {
var queryResults = query.execute();
queryResultsView = new QueryResultsView({collection: queryResults});
- /* Shove the query string into the static link */
+ /* Update the URL to reflect the search */
searchQuery = queryResults.url().split("?")[1];
- $("#static-search-link").attr("href", root_url + "?" + searchQuery).show();
+ history.pushState({}, "Zipkin", root_url + "?" + searchQuery);
return false;
};
@@ -546,10 +546,6 @@ Zipkin.Application.Index = (function() {
return false;
});
- $(document).on("click", "li.trace", function(e) {
- history.pushState({}, "Zipkin", root_url + "?" + searchQuery);
- });
-
Zipkin.Base.initialize();
var params = Zipkin.Util.queryParams();
View
1  zipkin-finatra/src/main/resources/templates/index.mustache
@@ -47,7 +47,6 @@
<div class="sidebar-block filter-block-contents filter-submit">
<button class="btn primary" disabled>Find traces</button>
<a data-toggle="modal" href="#lookup-help-modal" class="btn"><i class="icon-info-sign"></i></a>
- <a id="static-search-link" class="hide pull-right">link</a>
</div>
</form>
Something went wrong with that request. Please try again.