Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ui: catch binary annotation conversion errors #192

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

franklinhu commented Oct 24, 2012

Converting a malformed binary annotation throws exceptions that break the UI. In this case just catch the exception and say it could not be read.

Contributor

johanoskarsson commented Oct 24, 2012

+1

Contributor

johanoskarsson commented Oct 24, 2012

Perhaps add a test?

@adriancole adriancole added a commit that referenced this pull request Jun 3, 2016

@adriancole adriancole Merge pull request #192 from openzipkin/cassandra-selftracing
Adds cassandra client-side self-tracing
8e91e35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment