collector: Default to sample all spans in dev config #195

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@franklinhu

No description provided.

Franklin Hu added some commits Oct 31, 2012
@johanoskarsson johanoskarsson commented on an outdated diff Oct 31, 2012
zipkin-collector-service/config/collector-dev.scala
@@ -60,6 +62,9 @@ new ScribeZipkinCollectorConfig {
override def adaptiveSamplerConfig = new NullAdaptiveSamplerConfig {}
+ /* Default to sample everything */
@johanoskarsson
johanoskarsson Oct 31, 2012

Perhaps describe what the collector sampling stage does in a bit more detail here? Mention that if the collector gets too much traffic the next step would be to use the adaptive sampler.

Franklin Hu Moar docs f3d0c66
@franklinhu franklinhu closed this in 193fb04 Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment