Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armeria Server Configurator to Consumer Server Builder #2912

Closed
wants to merge 1 commit into from

Conversation

@jeqo
Copy link
Member

jeqo commented Nov 7, 2019

Replacing Armeria Server configurator with ServerBuilder consumer to add services.

@anuraaga this PR is to showcase that replacing configurator with consumers is not working out-of-the-box. I did this to check that is not something related to [1], and might be related with how Zipkin server is configured.

[1] openzipkin-contrib/zipkin-storage-kafka#61

Anyhow, I'm fine keeping configurator in both Zipkin and Kafka Storage if it's required; and we can close this if you agree.

@anuraaga

This comment has been minimized.

Copy link
Contributor

anuraaga commented Nov 8, 2019

Hmm that's weird - but yeah I'm fine with closing this and leaving as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.