Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use react-fontawesome instead of using fontawesome directly #2937
Before, Zipkin Lens used Font-Awesome directly, but I think this way has the following problems.
I think it is better to use Font-Awesome through React components provided by Fort-Awesome (https://github.com/FortAwesome/react-fontawesome).
Sorry for big changes.
The SidebarMenuItem component received a FontAwesome icon string as props.
So it was necessary to change SidebarMenuItem's props when migrating the library.
If possible, I would appreciate it if you could review this change within this PR...