Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanity Share Tokens #123

Closed
michaelquigley opened this issue Nov 30, 2022 · 4 comments
Closed

Vanity Share Tokens #123

michaelquigley opened this issue Nov 30, 2022 · 4 comments
Assignees
Labels
enhancement Enhancement of an existing feature spike Spikes
Milestone

Comments

@michaelquigley
Copy link
Collaborator

We could introduce the concept of "vanity tokens".

@michaelquigley michaelquigley added enhancement Enhancement of an existing feature spike Spikes labels Nov 30, 2022
@michaelquigley michaelquigley added this to the v0.4 milestone Nov 30, 2022
@michaelquigley michaelquigley self-assigned this Dec 22, 2022
@michaelquigley michaelquigley changed the title Vanity Service Tokens Vanity Share Tokens Feb 15, 2023
@surennaidu
Copy link

surennaidu commented Mar 15, 2023

@michaelquigley +1 as this was an ask from Resulticks as well.

@qrkourier
Copy link
Member

A related idea is a DNS alias. I would use an alias, i.e., a custom domain name, for a long-lived share. While useful, this would add some ambiguity around how a share is accessed, which may be a worse experience. The ambiguity would stem from the introduction of an alias which is not the same thing as a share token. An alias could have an arbitrary DNS zone whereas a share token is a subdomain of the zone allocated for zrok.

@michaelquigley
Copy link
Collaborator Author

@michaelquigley
Copy link
Collaborator Author

Note: vanity share tokens should really only be available for reserved shares; ephemeral shares by nature are ephemeral and probably don't need a convenient name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature spike Spikes
Projects
Development

No branches or pull requests

3 participants