Permalink
Commits on Aug 20, 2017
  1. Merge pull request #1394 from operable/cm/get-tests-working-again

    christophermaier committed Aug 20, 2017
    Disable HipChat integration tests for now
  2. Disable HipChat integration tests for now

    christophermaier committed Aug 20, 2017
    Unit and Slack integration tests work, but some timeout issues need to
    be tracked down on the HipChat side of things. See #1395 for more.
    
    We can disable the HipChat tests for now, so we can benefit from Travis
    CI builds on other PRs.
Commits on Mar 28, 2017
  1. Actually use the same config Ebert uses [skip ci]

    christophermaier committed Mar 28, 2017
  2. Use the Operable styleguide repository for Ebert

    christophermaier committed Mar 28, 2017
    Also remove direct Credo dependency, and add an Ebert badge to the README.
Commits on Mar 22, 2017
  1. Merge pull request #1381 from operable/cm/1377-fix-slack-tests

    christophermaier committed Mar 22, 2017
    Get Slack tests working again
Commits on Mar 19, 2017
  1. Get Slack tests working again

    christophermaier committed Mar 19, 2017
    It appears that Slack is now sending recently-sent messages to a client
    when it connects. That is, it's possible to receive messages sent before
    you actually connect. This was causing lots of random failures in the
    tests, because we would end up making assertions on messages sent in
    response to previous tests! The actual functionality of the Slack
    provider was fine; this was purely a testing issue.
    
    Many changes were made to clean and tighten up the tests (detailed
    below), but the big take-home is that we now pay attention to message
    timestamps to determine whether to process a message or not.
    
    An overview of what was done:
    
    * Run Slack tests in Travis CI
    
    * Create a Slack client once per Slack suite, as opposed to once per
      Slack *test*.
    
      Though not strictly necessary, this reduces the chances of running
      afoul of Slack's throttling, which results in shorter overall test
      runs.
    
    * Update Slack tests to send test-specific messages.
    
      Previously, we'd send a lot of "echo blah" or "echo $TIMESTAMP"
      messages. Once Slack started apparently sending recently sent messages
      upon connection, this made for some hard-to-track-down false postives
      and timeouts. Now that every test sends unique (and traceable)
      messages, it's much easier to figure out what messages are being
      matched.
    
    * Clean up and refactor the testing Slack client
    
      In the course of debugging the tests, I discovered extra code in the
      testing Slack client (and its `SlackClientState`) that wasn't actually
      being used. For instance, we would store messages, but not actually do
      anything with them. We also never join a specific channel when
      connecting our test client (that is taken care of when setting up the
      Slack accounts, anyway), so that code is out. Finally, we don't
      currently test anything with edited messages, so that functionality is
      out, too.
    
      Additionally, we now explicitly pay attention to the timestamp of
      messages. When we send a message, we note its timestamp and only
      process responses with a greater timestamp.
    
    Fixes #1377
Commits on Mar 15, 2017
  1. Merge pull request #1379 from operable/cm/travis-hipchat

    christophermaier committed Mar 15, 2017
    Add HipChat tests to Travis
  2. Add HipChat tests to Travis

    christophermaier committed Mar 15, 2017
  3. Merge pull request #1378 from operable/cm/travis-badge

    christophermaier committed Mar 15, 2017
    Add Travis badge [skip ci]
  4. Add Travis badge [skip ci]

    christophermaier committed Mar 15, 2017
    Oops, forgot this :(
  5. Merge pull request #1376 from operable/cm/travis

    christophermaier committed Mar 15, 2017
    Run unit tests in Travis
  6. Run unit tests in Travis

    christophermaier committed Mar 14, 2017
Commits on Mar 7, 2017
  1. Merge pull request #1374 from operable/cm/remove-buildkite-badge

    christophermaier committed Mar 7, 2017
    Remove old Buildkite badge
Commits on Feb 23, 2017
Commits on Feb 22, 2017
  1. Merge pull request #1372 from operable/cm/changelog

    christophermaier committed Feb 22, 2017
    Changelog for 1.0.0-beta.3 [skip ci]
  2. Merge pull request #1366 from operable/cm/chat-handle-changeset

    christophermaier committed Feb 22, 2017
    Check assigning a chat handle to more than one user
  3. Merge pull request #1369 from operable/mechanic/update-deps

    christophermaier committed Feb 22, 2017
    Update Operable dependencies to latest
Commits on Feb 21, 2017
  1. Check assigning a chat handle to more than one user

    christophermaier committed Feb 21, 2017
    If another user has already claimed a given chat handle, deal with the
    error gracefully, instead of crashing the web controller.
  2. Merge pull request #1360 from operable/cm/refactor

    christophermaier committed Feb 21, 2017
    Refactor the Dockerfile
  3. Address review comments

    christophermaier committed Feb 21, 2017
Commits on Feb 17, 2017
  1. Take advantage of Docker build cache

    christophermaier committed Feb 17, 2017
    By splitting up the files we copy, we can get quicker builds.
  2. Move chown to save a costly layer write

    christophermaier committed Feb 17, 2017
    `chown` basically makes a new layer the size of everything that just got
    `chown`ed. It turns out we only need the directory to be owned by the
    operable user; none of the files really need to.
  3. Don't use cache

    christophermaier committed Feb 17, 2017
  4. Merge pull request #1357 from operable/cm/oopsie

    christophermaier committed Feb 17, 2017
    Make Cog run again
  5. Make Cog run again

    christophermaier committed Feb 17, 2017
  6. Merge pull request #1356 from operable/cm/build-with-cogctl

    christophermaier committed Feb 17, 2017
    Build images with new Python cogctl binary
Commits on Feb 16, 2017
  1. Build images with new Python cogctl binary

    christophermaier committed Feb 16, 2017
  2. Merge pull request #1355 from operable/cm/disable-image-building

    christophermaier committed Feb 16, 2017
    Temporarily disable image building