New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Operable styleguide repository for Ebert #1382

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@christophermaier
Collaborator

christophermaier commented Mar 28, 2017

Also remove direct Credo dependency, and add an Ebert badge to the README.

Use the Operable styleguide repository for Ebert
Also remove direct Credo dependency, and add an Ebert badge to the README.
@christophermaier

This comment has been minimized.

Show comment
Hide comment
@christophermaier

christophermaier Mar 28, 2017

Collaborator

Ebert has finished reviewing this Pull Request and has found:

  • 129 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/operable/cog/pulls/1382.

Collaborator

christophermaier commented Mar 28, 2017

Ebert has finished reviewing this Pull Request and has found:

  • 129 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/operable/cog/pulls/1382.

@davejlong

This comment has been minimized.

Show comment
Hide comment
@davejlong

davejlong Aug 14, 2017

Member

I'd suggest leaving the Credo dependency in as it's something that contributors should be running before they try to push up a PR.

Member

davejlong commented Aug 14, 2017

I'd suggest leaving the Credo dependency in as it's something that contributors should be running before they try to push up a PR.

@davejlong davejlong merged commit 5bd3378 into master Oct 12, 2017

4 checks passed

dependency-ci Dependencies checked
Details
ebert Ebert has found 129 fixed issues.
Details
licence/cla Contributor License Agreement is signed.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment