Reduce compile-time file coupling #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several cyclic compile dependencies caused by
use Cog.Modelsanduse Cog.Queries. Modules, tests, test support modules, and migrations making use of either of these modules have been edited to explicitly alias the models and/or queries used.Cog.ModelsandCog.Querieshave been deleted as well.To quantify the impact I measured the number of files compiled after touching
Cog.Models.Userand the average compile time for 5 compiles. Compilation time was measured with$MIX_ENV=prod, deps precompiled, andmix cleanperformed before each compile.Cog.Models.UserThere's definitely more work we can do to further reduce compile-time coupling but I believe this is a good first step.