Task dfl 3042 ev listener #30

Merged
merged 9 commits into from Aug 3, 2012

4 participants

@chriskr
Opera Software member

No description provided.

@hzr
hzr commented Aug 3, 2012

All fine!

@chriskr
Opera Software member

@hzr @danfooo added some more fixes.

@danfooo

Maybe

|| ""

at the end of this line? Without that, _short_url can stay undefined.

AFAICS, host can never be undefined.

But if you happened to give for example a relative URL to the class, short_url would be retested on every access. You shouldn't though, but it's a very small change too.

Opera Software member

After parsing host is at least the empty string.

Ah, good.

@hzr
hzr commented Aug 3, 2012

Looks fine!

@danfooo

Now that I see the name in code I have to think of url shortening in the sense of bit.ly or similar. But I don't have a better suggestion right now, so I'm okay with it.

@chriskr chriskr merged commit 0ef4763 into task_DFL_3042_ev_listener_reviewed Aug 3, 2012
@p01
Opera Software member

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment