Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

DFL-3615: Line Wrap setting doesn't work if a table with long strings is... #77

Merged
merged 2 commits into from

4 participants

@danfooo

... shown in the network details view

Daniel Herzog DFL-3615: Line Wrap setting doesn't work if a table with long strings…
… is shown in the network details view
c465986
@hzr

Looks fine.

@chriskr
Owner

Looks good.

Owner

Good.
Had to read up about table-layout :p

Daniel Herzog DFL-3617: Clicking the tiny triangle preceeding the Request and Respo…
…nse headlines in the Network detail overlay only apply to the Request
f11dc8f
@danfooo

One more..

@chriskr
Owner

Looks good.

Owner

Good.
Just tested locally ;)

@danfooo

Cool, thanks :)

@danfooo danfooo merged commit ba2aa44 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 20, 2012
  1. DFL-3615: Line Wrap setting doesn't work if a table with long strings…

    Daniel Herzog authored
    … is shown in the network details view
  2. DFL-3617: Clicking the tiny triangle preceeding the Request and Respo…

    Daniel Herzog authored
    …nse headlines in the Network detail overlay only apply to the Request
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 2 deletions.
  1. +1 −0  src/network/network_style.css
  2. +2 −2 src/network/network_view.js
View
1  src/network/network_style.css
@@ -340,6 +340,7 @@
.network-detail-overlay .wrap table
{
width: 100%;
+ table-layout: fixed;
}
.network-detail-overlay td,
View
4 src/network/network_view.js
@@ -841,9 +841,9 @@ cls.NetworkDetailOverlayViewPrototype = function()
return templates.network.details(entry);
};
- this._on_toggle_expand_request_response = function(event)
+ this._on_toggle_expand_request_response = function(event, target)
{
- var key = event.target.dataset.isResponse ? "expand-responses" : "expand-requests";
+ var key = target.dataset.isResponse ? "expand-responses" : "expand-requests";
var set_active = !settings["network-detail-overlay"].get(key);
settings["network-detail-overlay"].set(key, set_active);
this.needs_instant_update = true;
Something went wrong with that request. Please try again.